[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 0/4] xen: rework compat headers generation
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 1 Jun 2022 17:17:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i3YrQFEUT1vDBhQnJgFaO4yKn/IKEH7GluQ0X6ZOKKg=; b=Smqf9MEkvrA2ijaEynQ2oMvFxJ3z2Oe4pRmB1Jv43Fc2Td/mYA+lScdj9GTageDeII35x/Eyvy1Z0SZ9M1ELJq/f+DI2USlv/jbIKkJTRyjXzRI2RMw7EQV3ZgRQ+c6myNSkAPiZ65JyBaFzlQOanMiIQElLMq9l1gCCcnfS0AdV/zDNLzvwvX7SP3DS+IdJXiI6zmyLMZ5jbciIn/QK+i5zPA3CzKPKV++F8RaX5rLsFad8xaM1nisGOWod3KbGpn5t3WepkMRXZMgnPNdOBv1REgQmf+EhH5skGFoASoCBRbaRmVPEP8mh9XuxK+9gKM0Ryuy4A3WXStKfgA34iA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLRQdw9WkIuM8mbPPh9G3Iq5sdbYwk3B8rhBMFDBraxj0S05CqWuihXkZsLVb+41C+06gD0j7RscKeQ7bvBtTnBAx7HWcBZv2Ei5rNXBoHhT1WxSE20K+a65V5awutr9+ila7r4z9+BzJvIgQLO3B6pANnG1QxEstd3+lEBe0Aofz25ynSNGxyajSM2EnIhQwnPc08GpAJRje9VPADt8GzTl651vFc9RU8p0yKhhbMnyt8Q+4wm8V3tOszhXIv9EdxtkIi+DkDR0VcsyAfDH0a9Pi0wGc12pAmBF3u3ONQDQqTFW0SbPZK7rjqjkIcGWs+wdrCRY0/TtTgP2U2q0aQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 01 Jun 2022 17:17:52 +0000
- Ironport-data: A9a23:041Nk6oAenV+PhRmp8jhGLlZ+F5eBmIDZBIvgKrLsJaIsI4StFCzt garIBmEOquKZGLyLdh2YIq/p0xVvsLdm9RrTlA4+3szRSwb8ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvT4 Yqq+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBHKnskcIEVR9hDR5hJJ9MpLDOMSPirpnGp6HGWyOEL/RGKmgTZNRd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp2JEm8fX2P qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyzeJklAgj+G1WDbTUuWSQ5h5rBa4n VLfr2WnAikdZcST1jXQpxpAgceKx0sXQrk6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL FYbkgIssKwz+UqDXtT7GRqirxasvBQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBebScxy laDktftBDpumL6YU3SQ8vGTtzzaBMQOBWoLZCtBRw1V5dDm+dg3lkiWEIclF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw==
- Ironport-hdrordr: A9a23:TaQWnqHttr1Ry+RKpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYddjyz0tXrY3j20Cs3apay7U+za06y0cA
- Thread-topic: [XEN PATCH 0/4] xen: rework compat headers generation
On 01/06/2022 17:59, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> br.build-system-xen-include-rework-v1
>
> Hi,
>
> This patch series is about 2 improvement. First one is to use $(if_changed, )
> in "include/Makefile" to make the generation of the compat headers less
> verbose
> and to have the command line part of the decision to rebuild the headers.
> Second one is to replace one slow script by a much faster one, and save time
> when generating the headers.
>
> Thanks.
>
> Anthony PERARD (4):
> build: xen/include: use if_changed
> build: set PERL
> build: replace get-fields.sh by a perl script
> build: remove auto.conf prerequisite from compat/xlat.h target
>
> xen/Makefile | 1 +
> xen/include/Makefile | 106 ++++---
> xen/tools/compat-xlat-header | 539 +++++++++++++++++++++++++++++++++++
> xen/tools/get-fields.sh | 528 ----------------------------------
Excellent. I was planning to ask you about this. (I also need to
refreshing my half series cleaning up other bits of the build.)
One trivial observation is that it would probably be nicer to name the
script with a .pl extension.
Any numbers on what the speedup in patch 3 is?
Are the generated compat headers identical before and after this
series? If yes, I'm very tempted to ack and commit it straight away.
~Andrew
|
