[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 7/8] xen/x86: add detection of memory interleaves for different nodes


  • To: Wei Chen <Wei.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 2 Jun 2022 10:32:13 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sYw7DR/++nnzD2xe4Y41/Rg7EXl+Gj32T/ZsfmyxtW8=; b=Dpoc9SIYIVY/P6rVgGr2+OyWOGBtOOFNOTXgUdW2WyvCVz+BAS9QN1MupP467QdXisAlXmHrU0ut8ByDf0FJ72MYToIUnxMjHi2jIpjC0pGxV6FAQQe0LJLg7j+Eb6OWj59yhWcrBdrLOPQkmK4h0T46bGXPYu8oLyX4KFJsorFUMz/ErTBEylWo3hUdyj9xtBwkUTyFnbWeEqdeDTzQYGrBY4ahPGI0MnWjSJZfiw70CHaxKH5/r2CuXgFdVvsDrkCnzRAtFRWkCyjFy/ouC6IA6u6sfeRXJYjy0dEQh7JSsGezq8PZd8v4uZWtU96EsVeSK3exnzoDw+ywLmbYRQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O0WtDOQbdmh97KpPpdZ2rh+PwY4JNkw31IjDe+iEUaeKLrL+BLwqEAPUYR8awskSlJWzEe38z1cMrYG6oLXXKtojyAILwlVWxnlRLcAYkCU0E3Ue7TdwNbHQDT2Xpv8cIwEaIkpAAaCsjmfbBF5/qLXS7C7z2sdmmCScn4Mgfe1Sb2F0HuWEuJIrWD3Z+LV+vEnq/R77dzk41lZoYOrndfKFLv2qJo004wnu/tTg9YwjoVV4cffeHn8pH8x0EDTPCXmxT1/SE4QO1FGAmQNmeMymEqc7bzhiORd6aoaMi2+iLoCngt4mUGjj7GOabc+Kk0azzXXW9jSKMvMVEI/Jtg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jiamei Xie <jiamei.xie@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 02 Jun 2022 08:32:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.06.2022 06:10, Wei Chen wrote:
> Hi Jan,
> 
> On 2022/5/31 21:21, Jan Beulich wrote:
>> On 23.05.2022 08:25, Wei Chen wrote:
>>> @@ -119,20 +125,45 @@ int valid_numa_range(paddr_t start, paddr_t end, 
>>> nodeid_t node)
>>>     return 0;
> 
>>
>> To limit indentation depth, on of the two sides of the conditional can
>> be moved out, by omitting the unnecessary "else". To reduce the diff
>> it may be worthwhile to invert the if() condition, allowing the (then
>> implicit) "else" case to remain (almost) unchanged from the original.
>>
>>> -   } else {
>>> +   }
>>> +
>>> +   case INTERLEAVE:
>>> +   {
>>>             printk(KERN_ERR
>>> -                  "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with 
>>> PXM %u (%"PRIpaddr"-%"PRIpaddr")\n",
>>> -                  pxm, start, end, node_to_pxm(memblk_nodeid[i]),
>>> +                  "SRAT: PXM %u: (%"PRIpaddr"-%"PRIpaddr") interleaves 
>>> with PXM %u memblk (%"PRIpaddr"-%"PRIpaddr")\n",
>>> +                  node, nd_start, nd_end, node_to_pxm(memblk_nodeid[i]),
>>
>> Hmm, you have PXM in the log message text, but you still pass "node" as
>> first argument.
>>
>> Since you're touching all these messages, could I ask you to convert
>> all ranges to proper mathematical interval representation? I.e.
>> [start,end) here aiui as the end addresses look to be non-inclusive.
>>
> 
> Sorry, I want to confirm with you about this comment again. Now the 
> messages look like:
> (XEN) NUMA: PXM 0: (0000000080000000-00000008d8000000) interleaves...
> 
> So I want to know, is it [0000000080000000-00000008d8000000) or
> (0000000080000000-00000008d7ffffff) addressed your comment?
> Literally, I think it's case#1?

The former or [0000000080000000-00000008d7ffffff]. Parentheses stand for
exclusive boundaries, while square brackets stand for inclusive ones.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.