[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/9] xen: do not free reserved memory into heap
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 2 Jun 2022 11:23:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wr7Z/Fosh+oBdriOy2r/m8ovEcSH8S2+SZzmoD/iwG0=; b=KHHS/itU4KTNVhOClAM961xKhdro2tRZ8dOAWdc1Q2IJXe3sSbZSpk3RUmZVFSxVbgmsnZ85jpfUDaNjPyN9nQPiTEhUoCTRph9j3arJkAxfrd6GZr/14pYJ18zX79VPaQpS2D/1mlfxHRV/RV3MKCpmFWqR9+ca08cFzf1KUDfgq5WHqVhbZBJocSiC26Z7432h9Q/GaPXy3JZXYin4G/muJ6IsHtnZ3yJbe4YIrXnckYb+EvmNy0BjAts0UO1ruxqXoa3zg3SCHqHN9QAkGHY5+7C5eaO2gXT/hehlnq4+1bJfNP4aT7C34Hw30g9rEByizMkMdzvTFjBUbiXG9A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5u3u7SJVWdznnUQYViMoluA13O73dCqqnSwh8W+bGG+17zLSAnT3Ou0ipZrLdA1CcjB70F/iY42a60vtmvVXxZL1VcbB3EbXMsJ5cg8sdpeaLkeNfC0N/4kdV6/A47RF9f9Zm8GU/9Q5O3TcSosRzzlRtMBRr9BfsR3wLZLePclcjVJPYFjOfOsHF5iEKKefAp5A032pm49BFytiDHRw0P4U5cLJa8ehbc2IOJkiZlxOaKvBSpXc9OKuENHbVxmolDo8hQb0p6vnsDefdSFmGxCk7GDha0Siqaj/TeUGdCfG8c9SAHFChdiGpemP94wrUkMPiKJQ3wCSziH817NCA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 02 Jun 2022 09:23:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.06.2022 04:18, Penny Zheng wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Tuesday, May 31, 2022 4:37 PM
>>
>> On 31.05.2022 05:12, Penny Zheng wrote:
>>> --- a/xen/common/page_alloc.c
>>> +++ b/xen/common/page_alloc.c
>>> @@ -151,10 +151,6 @@
>>> #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL)
>>> #endif
>>>
>>> -#ifndef PGC_staticmem
>>> -#define PGC_staticmem 0
>>> -#endif
>>> -
>>
>> Is the moving of this into the header really a necessary part of this change?
>> Afaics the symbol is still only ever used in this one C file.
>
> Later, in commit "xen/arm: unpopulate memory when domain is static",
> we will use this flag in xen/arch/arm/include/asm/mm.h
IOW you want to move this change there.
Jan
|
