[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu option to xl.cfg
- To: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 3 Jun 2022 15:43:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQR9zYVAX1Kqo90P5iiXDcawPbH4FFqZT3c/W4o1Y/E=; b=RJEJcFWQc3a+qjs0B47UxslNQebyvx3wUAXcEHuc/Apf+1rz7m8Wvs0mJPqVluuFn5dp4wWXAKfns1QLfw4K6PvHDWepYbqK5fe7izqyY/7Qos1Ju6Xqvk2wXuJJ7uATYZp1d3GoIa60jzbJ8/htX1JVlQWl99keRnScwGydyURPxbqwAUhT14c4aZ9dquMBKnzLOQSqryH9gAKczAtR/WFECvT2RvLIcNPVwImZGFikviNd0HtNLFDWhLOWPOLkRRTjM3fCpOQNq7O8ZUZKqXu3eLFqu/FFodKaP/5F+Oz1xSSO4rbSYT55E3pq3AknkJXIW+//gZvleetvfXYLnQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WL9FPfrR2U/8xVe6VjIYXtYBAmPjCKYW8J0FpmqbwWh9r2lj6mVFhbmGEyPuUZbgVfdczImmzuCzQ70UhRHRpe7OOT7tnIYGCMflUR86pS/4BQfkCv8tZPdUl+Y9I8vcA5wHCLKYBGgYM8VMoBoggWVdfGgJBQom2HcGPtigNrH2IdhfjIyb8jKE5I8XBzOoy09e2x/lnbR3vnH/kotLQFEf2vBNdgEc8xoOw+f+fUUx9X87OXOpxglZ6BPBbfTqg5SFlZMDMTWQdjVzJiEhqbEPWIuWyOtQQpa0lGCn+wT28CVAW4SlfKnlNJFCv5EdPVq5drnpLw2gZg9cUErcAQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Fri, 03 Jun 2022 13:44:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.02.2022 19:00, Oleksii Moisieiev wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -512,7 +512,7 @@ static int sanitise_domain_config(struct
> xen_domctl_createdomain *config)
>
> if ( iommu )
> {
> - if ( config->iommu_opts & ~XEN_DOMCTL_IOMMU_no_sharept )
> + if ( config->iommu_opts >> XEN_DOMCTL_IOMMU_MAX )
> {
> dprintk(XENLOG_INFO, "Unknown IOMMU options %#x\n",
> config->iommu_opts);
While in common code this is perhaps okay, the new bit wants rejecting
(or also implementing) for x86.
> @@ -534,6 +536,7 @@ int iommu_do_domctl(
> {
> int ret = -ENODEV;
>
> +
> if ( !is_iommu_enabled(d) )
> return -EOPNOTSUPP;
Please don't.
> @@ -542,7 +545,7 @@ int iommu_do_domctl(
> #endif
>
> #ifdef CONFIG_HAS_DEVICE_TREE
> - if ( ret == -ENODEV )
> + if ( ret == -ENOSYS )
> ret = iommu_do_dt_domctl(domctl, d, u_domctl);
> #endif
Why?
Jan
|
