[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [RFC PATCH 00/12] Add Xue - console over USB 3 Debug Capability


  • To: "Marczykowski, Marek" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Lengyel, Tamas" <tamas.lengyel@xxxxxxxxx>
  • Date: Mon, 6 Jun 2022 13:18:42 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWEnTEfdQTb5DG67CdP92HYnY9l85AiyiKxAnrOb/tc=; b=lD7qoLA29rx9b+LwkRALsnfQDr3Z8iZgdZ+qC5PmzzwHOPoabGsQdCQyBzfI4wzzuQ3dKd3HsA2PpUtTI9dRJvglzyebJ0yiLWHoVrUc3AkCJUt08/tTLqYYobx/Rjk2EW5fd6pSns6nLW5SZ+XqhpXtPSMyrlaDEvXV+fbyjEghwf06+FrINGvNOCp4GTWud2EHQpFwnK2ncRfo4kG/kMmEQD+InLWCqK0XSc9+QaoJsWC4+jPYz35dhlAt6g2ZbzQizmHHJ55lzBQeGYARBtCmi74jJAI+U6Q535IcpLk5vSOjQm0ZY5eGx+z071/lZjkrIEUx2mTnsZ5emdCS9w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OR+ZwsoM6r60VYp7iXIvBKtWuJ7o/5ooH9zf/Q7oQ7T5AZ6rG/0CgRxLBtInKdo+w6k9CwI5pB+WTU7hVEs9GzrgydVSN/RSnwfwPXi2IR/trOC1yG/a1ZQvX8kC+tU31z8FctaEKqG8NdCHbhToUeeaEyO3d2YF6vuQVxxSNgFIq5fJkXUbiPkQYC2abiBVoqg2SU9TN5DbzOtb17biCj1rkvgXwxCPjqnfAT/IIch8teN1wio0ZQPF0M1ekqzaEsrGTvwY4uybxvTIKGU/Q3U8q5z7ROVI7q3F7HK67vG7aXf6goUa3nul8ke+a/WuYK+tPfC9PixOoeSQnOI2vQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
  • Cc: "Marczykowski, Marek" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Beulich, Jan" <JBeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 06 Jun 2022 13:19:12 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version: 11.6.500.17
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYeVd8ujqeRGJ5skKWtq2o4Wh0c61CXJcg
  • Thread-topic: [RFC PATCH 00/12] Add Xue - console over USB 3 Debug Capability

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Marek
> Marczykowski-Górecki
> Sent: Sunday, June 5, 2022 11:40 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Marczykowski, Marek <marmarek@xxxxxxxxxxxxxxxxxxxxxx>; Cooper, Andrew
> <andrew.cooper3@xxxxxxxxxx>; George Dunlap <george.dunlap@xxxxxxxxxx>;
> Beulich, Jan <JBeulich@xxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Pau Monné, Roger
> <roger.pau@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; Tian, Kevin
> <kevin.tian@xxxxxxxxx>
> Subject: [RFC PATCH 00/12] Add Xue - console over USB 3 Debug Capability
> 
> This is integration of https://github.com/connojd/xue into mainline Xen.
> This patch series includes several patches that I made in the process, some 
> are
> very loosely related.
> 
> The RFC status is to collect feedback on the shape of this series, 
> specifically:
> 
> 1. The actual Xue driver is a header-only library. Most of the code is in a 
> series of
> inline functions in xue.h. I kept it this way, to ease integrating Xue 
> updates.
> That's also why I preserved its original code style. Is it okay, or should I 
> move the
> code to a .c file?
> 
> 2. The xue.h file includes bindings for several other environments too (EFI, 
> Linux,
> ...). This is unused code, behind #ifdef. Again, I kept it to ease updating. 
> Should I
> remove it?
> 
> 3. The adding of IOMMU reserverd memory is necessary even if "hiding" device
> from dom0. Otherwise, VT-d will deny DMA. That's probably not the most
> elegant solution, but Xen doesn't have seem to have provisions for devices 
> doing
> DMA into Xen's memory.
> 
> 4. To preserve authorship, I included unmodified "drivers/char: Add support 
> for
> Xue USB3 debugger" commit from Connor, and only added my changes on top.
> This means, with that this commit, the driver doesn't work yet (but it does
> compile). Is it okay, or should I combine fixes into that commit and somehow
> mark authorship in the commit message?
> 
> 5. The last patch(es) enable using the controller by dom0, even when Xen uses
> DbC part. That's possible, because the capability was designed specifically to
> allow separate driver handle it, in parallel to unmodified xhci driver 
> (separate set
> of registers, pretending the port is "disconnected" for the main xhci driver 
> etc).
> It works with Linux dom0, although requires an awful hack - re-enabling bus
> mastering behind dom0's backs. Is it okay to leave this functionality as is, 
> or
> guard it behind some cmdline option, or maybe remove completely?

Happy to see this effort, it's been long overdue to get this feature upstream! 
If you have a git branch somewhere I'm happy to test it out. I already have 
tested Xue before on my NUC and it was working well.

Thanks,
Tamas

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.