[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] xsm: properly handle error from XSM init
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 7 Jun 2022 15:21:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoKlRfCzoBq5luuz09Ka/Zz1sWvP7iEM7NgBl5PN9qc=; b=QXcLTpAqOimKVs1A5g5WbTkkNUuZ2Q59FdohFBIg7H01wNLD9ueWfupUXb+mSU28diX93TIgoDi9ElGZ53mH276yflzkW8xavudWjfHY6iHzZLfr4VrpQgoatCiWrtm9oYLVruYakJs0iUgFrCyayslFhp2jMMLIHQ0I3UwM2BCY0ASU08kS3wsoc03Az5jCnuqspDjtxXvvkddYLHCneAcYacAXvhj+ZX+dX4lkot63iZKM9aJkwhTw3+GNhbrN6JhKSEHj8Ob3Ony/mKal7vNu4epzOmub2LiKONdh3GmRROoHaMX75rEurbWPzPPd5Q8mCp1pYnb6U81fb2DMuA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UqPzMrZ7M2vwh++Q4FCnKJcLGwZN7bhhKCkHWbLLADoouFdRVewXZoXXm9HW1mWecyGL7pps3dcumKNKG59enICEsqYoZ2PDo1Uvb1/ejO2ib5HxEHtb/p1xnKgDvuQFWYRE/74MygYTFqYpXpa6kRoBh3WvQtffzBtA2KiD8/pNiZvkhy2bskno7dLMopYK1hkQ7WpQte+ZLKzvQO9171CudwiXKF77B0brjIQ0Nv8s6+am17q7RPZR6kgzxbVfpvXsi8WCn4fLimvD359rzs06+/LWHcBdenih8z/K22vRkdjCUwZpTuW5NFHMExH9TERUc9rq8dO1XjoDp0GBAA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: scott.davis@xxxxxxxxxx, christopher.clark@xxxxxxxxxx, jandryuk@xxxxxxxxx, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 07 Jun 2022 13:21:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.06.2022 14:14, Daniel P. Smith wrote:
> On 6/1/22 02:14, Jan Beulich wrote:
>> Now that return values are checked, I think that in addition to what
>> you already do the two function declarations may want decorating with
>> __must_check.
>
> Understood but likely not necessary based on Andy's review suggestion to
> move these functions to void.
Of course - once they return void, they cannot be __must_check.
Jan
|
