[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: MISRA C meeting tomorrow, was: MOVING COMMUNITY CALL Call for agenda items for 9 June Community Call @ 1500 UTC
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 9 Jun 2022 09:04:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sh6OEi6dpaIq+cfESSujIAlMweqMyXandHtIlZg4miQ=; b=ZlXXHSLDmWB+Qp5YKJ+7SQD+hthh2Dwq4K2H3ZGIMqefK1h0XBnifrS04uPJsH2xK56QUvK+a2YAdU5dlMHnT1NmToFh18vi6bqWPsLzxKgTsev7ANmUtdC6fM/t4hl7wZTw8xxE43bu48ExZ/QcXVBK1KpNO4UJE/ODl9NV6HyorSgpPNlEu3OOvghlmptLnEdAw+u/juznGypcGPsgjnMXDrmEitMRaJJCfF+B95C1HO2eUgu1DSgmcLvsUY44IZh9lNNQeAZUvd0Fa6lxuCr089nkfo5SqYERidptR6/g9/WOGCz8fMCePz071nL4PExm816Y3dpzQ9H/9H3quw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FLpbkylwj2IlsWgKG//12fL8lR21Ssm3UlhzO6owcOjkwfYOqA5hUFSRVcJRuZAyPYas7RTjVcYxtL/sFxzA/poy+yhnAnJpyRkL1EXF2TDJq67kiJotRCtTLZ8HpzdD4xtR26vJUAv3LS8XEtPZfIhEuylIXgJWKPziB/jcQv8weJXd0cmXvob4yB9ZpzfXDyOchI0poH84orXp1UTzP8uRc0lwsxMoU3DjFfedHaimc1gi8nFvLmp0xz7WGZyn6V+rwAgXy7yRr4BX4wyiBZbtk+STiA4RI4U6xtjOBn+iUka0/ZHe5RWxTkZBOTVwlCpQ63FMiwK0ENT78BQ0fw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Andrew.Cooper3@xxxxxxxxxx, julien@xxxxxxx, Bertrand.Marquis@xxxxxxx, fusa-sig@xxxxxxxxxxxxxxxxxxxx, roberto.bagnara@xxxxxxxxxxx
- Delivery-date: Thu, 09 Jun 2022 07:05:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.06.2022 03:20, Stefano Stabellini wrote:
> Finally, for Rule 13.2, I updated the link to ECLAIR's results. There
> are a lot more violations than just 4, but I don't know if they are
> valid or false positives.
I've picked just the one case in xen/common/efi/ebmalloc.c to check,
and it says "possibly". That's because evaluation of function call
arguments involves the calling of (in this case two) further
functions. If those functions had side effects (which apparently the
tool can't figure), there would indeed be a problem.
The (Arm based) count of almost 10k violations is clearly a concern.
I don't consider it even remotely reasonable to add 10k comments, no
matter how brief, to cover all the false positives.
Jan
|
