[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/4] build: xen/include: use if_changed
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 9 Jun 2022 12:26:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xjjTI/ZsScrAkFB9KLCX3EUQq6oFWziO74v5KgCOXmI=; b=RpYYQZqtDpjidbWYwefjgVbMoJ/YbsYFbqkfoOYypFtahEkKshbpoqyFyRRODIZPPt6WU+APnVvlmblS4JDURIq4ASQfSZM4qGaxxw2gqn8tNxT5FujAzJiuv1vgRVzGIV2qd/rvtMy3y0nUCUSznTuooiVAAhuNiCWxK1OcPplDGDxeR3mvZRxZ0tfvaXHSUT20Um7GXpnaVbI5qesr7ku/Y5YHq+w+sf++tftFqmOCD/pGNf1CDMgk6Z0j7dQKRb5tbjoNsQqSOpFhH5sXQaSpF3ohnCUHLqN5hC8e9xn1RG90zxxAeC3IpPiRfV5uXSa5uVie3FFwjXJgekb17g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GLl1GzD6lA9Yjg0wLBtrRKbXcsD+P2zAg4fChgFRIq3Vngz7uxOS/8d/AxPAEhF8tOP8qrs0z0tvzO4kAoSQ5cWmSqQ9B4Xiaf8LXLUZ8brJcoOQt268ydvZmNRg+3vRh2/bntLG/akmN+zAkcs5+5sAoYCxQXcvhLiGbW8AYrB8P8pXnXDq+sKW2MewDzbQvLOpjOTChltzxdNVgKEhitRXAorV0lW3gPec1by+K9ElgE79Gv/RF7ET0bWDJQLB6LwXXsDGscqzyQRonp63Itm/7xZd1mmm3E9vJuUaLjWMAh2PUJ1k2sqmHeihUcLZc696Ir8dCmIE8AEaiTiQfA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 09 Jun 2022 10:27:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.06.2022 12:16, Bertrand Marquis wrote:
>> On 1 Jun 2022, at 17:59, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>>
>> Use "define" for the headers*_chk commands as otherwise the "#"
>> is interpreted as a comment and make can't find the end of
>> $(foreach,).
>>
>> Adding several .PRECIOUS as without them `make` deletes the
>> intermediate targets. This is an issue because the macro $(if_changed,)
>> check if the target exist in order to decide whether to recreate the
>> target.
>>
>> Removing the call to `mkdir` from the commands. Those aren't needed
>> anymore because a rune in Rules.mk creates the directory for each
>> $(targets).
>>
>> Remove "export PYTHON" as it is already exported.
>
> With this change, compiling for x86 is now ending up in:
> CHK include/headers99.chk
> make[9]: execvp: /bin/sh: Argument list too long
> make[9]: *** [include/Makefile:181: include/headers++.chk] Error 127
>
> Not quite sure yet why but I wanted to signal it early as other might be
> impacted.
>
> Arm and arm64 builds are not impacted.
Hmm, that patch has passed the smoke push gate already, so there likely is
more to it than there being an unconditional issue. I did build-test this
before pushing, and I've just re-tested on a 2nd system without seeing an
issue.
Also please remember to trim your replies.
Jan
|
