[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/mm: further simplify cleanup_page_mappings()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 9 Jun 2022 15:50:26 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yuceVizFDn5qDctsHHjXyyVu1GYqojQxEMbWf4ogXdE=; b=WQ6RxRiYdZjZeJIa8IYnp7D3JlOajXswfDVgCkB7McYUOxftA1ZhIGk2o1kr2G210EYhsDaaKgdMFAkPzynEaiB3D15Zffn8nfeK4f0B9YH6v2IgaF63UeTpeGavJEa9hLJhEaZ6Wf+MKgwoa0khhrxsy1RaB/cPV2D2rKzxoBxSx19a59QLhEhHRIMlAXq2rvALD/xiCf8oA+ogql4kY8iaf2OnHbmFgFjpXiWQ2DormMTC4zBIG2pNGGm0Y6UpmXEtMV576PvCQ9/MddjPgAGm5owkHn6dUditOYbdKlqqNcZdgEuZ0bcytOyeOrvlO3hYAeJlFGqrRn59Bc4fxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=guHFeR5unr6zjrTZf0lW0yJv2rfzN/Duf071u7uF6EG0Q6vo/RLQEYcwd1UJVdheihvF0V/F4LvOLsCet5mnS+RUQwWigUwK5gAMwvLh4DNXu9reGamwC9NEd+iCxchbcxE0q0XtfgcJCzyUn3XSLra/Uwk5vncE9Tfks2B8zjuGQhoR5o31GEr2vBFX8SvcxcT+TmQYCioT63Ib76882RXdqtaIpJr2DrBoMv9zvIABBjg0AC8F0J07B4WCken1DVMj7WEDzLUCN6t1Zxad0kMUmdUaEecRDTeEciLOUzhACAGooR+hnhMBBBhm+lrSX4DdgEtpN9Zfu5fdFhQvkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 09 Jun 2022 15:51:22 +0000
- Ironport-data: A9a23:EGk+c6Pw3ynXBG/vrR3XlsFynXyQoLVcMsEvi/4bfWQNrUoq1TMFx mJJUG7SOPzeY2anL4wga9m1pEIAu5TcxoUwTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZn2t4w2rBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9 oxuiKObRwQQI6z2g8YWfgh3UCZGIvgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHPuiCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IF+ArN/Ppsi4TV5CNy0byzDdqKQdfQGsJtgU+Xt E3az2usV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVQBmQsHOC+BkGVLJt//YS7QiMzu/Y5lifD21dFDpZMoV56okxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLTfDdYgHdcd0o/ w23kQ==
- Ironport-hdrordr: A9a23:bCz7zahng4cMjckUmdpkBoCpQ3BQX4N23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3PARDAhKd/apw7gpMycxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfdsRKEkjTVo+a07bWvHAUEcYZ tTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYYit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tXKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG7fIx8Z0WY9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/ G/fJpLHv6LFxqaJbp0
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYfBcxlHJGb8s4Mk+MGPtEwJgQia1HORaA
- Thread-topic: [PATCH] x86/mm: further simplify cleanup_page_mappings()
On 09/06/2022 16:39, Jan Beulich wrote:
> With the removal of update_xen_mappings() there's no need anymore for a
> 2nd error code variable to transiently hold the IOMMU unmap return
> value.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Oh - I'd not even spotted that simplification.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> I have to admit that I was tempted to get rid of PAGE_ORDER_4K at this
> occasion, as it feels awkward to me to have such in clearly x86-only
> code.
Happy for that to go too.
~Andrew
|
