[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 10 Jun 2022 17:21:27 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 10 Jun 2022 16:22:01 +0000
- Ironport-data: A9a23:6hUISalgT0UEQunJ7333XMvo5gxFJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOXGHQP/7bZmD0foh2PY62ph8O757cyddiQAJvr3tnFCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DnWlvV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYRwJxHO7litwmdiZ+Nz5xFPBl4/yYGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY uJGMmEzN0mQP3WjPH9UOKo3gMODnELNagFC9E6zhvcG0VXcmVkZPL/Fb4OOJ43iqd9utkSSq 3/C/m/5KgoHL9HZwj2AmlquifXIhjjTQ58JGfuz8fsCqEaI2mUZBRkSVF26ifq0kEizX5RYM UN80igzqak/8mS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebTsu2 1ySg8LyBRRgtbSUTTSW8bL8hSy2ETgYKykFfyBsZQwB7tr4qYc/lCXTX81jG664iN7yMTzoy jXMpy8774j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEqr61tbJ6e3X7eN1n7/8vlpcaWCDQa46 S1sd9el0AweMX2cvHXTHbldRuzyu6jt3C702gA2QcR4n9i50zv6JN0LvmkjTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONk1Hs3DaJo9zqx+HXAaIlmU XthTe6iDGwBFYNsxyesSuEW3NcDn35jmTyCFM6klU/9j9JygUJ5rp9UWGZik8hjtP/UyOkr2 4032zS2J+V3D7SlP3i/HX87JlEWN3krba3LRzhsXrfbeGJOQTh5Y9eImO9JU9E0xMx9y7aXl kxRr2cFkTITc1WccVXUAp2iAZuyNatCQYUTZ3B1YQn2hiB9OO5CLs43LvMKQFXuz8Q7pdYcc hXPU5/o7ihnItgfxwkgUA==
- Ironport-hdrordr: A9a23:kDX+TqikVpokmzzO8yve6exqJ3BQXuIji2hC6mlwRA09TySZ// rOoB0+726StN93YgBHpTngAtjlfZqyz/JICOUqUotKGTOWwVdAT7sSiLcKoQeQeBEWn9Q1vc wLHpSWSueAb2SS5fyKmDVQeOxB/DDoys6Vuds=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 31, 2022 at 12:06:53AM +0300, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> Reuse generic IOMMU device tree bindings to communicate Xen specific
> information for the virtio devices for which the restricted memory
> access using Xen grant mappings need to be enabled.
>
> Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma"
> compatible to all virtio devices which backends are going to run in
> non-hardware domains (which are non-trusted by default).
>
> Based on device-tree binding from Linux:
> Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml
>
> The example of generated nodes:
>
> xen_iommu {
> compatible = "xen,grant-dma";
> #iommu-cells = <0x01>;
> phandle = <0xfde9>;
> };
>
> virtio@2000000 {
> compatible = "virtio,mmio";
> reg = <0x00 0x2000000 0x00 0x200>;
> interrupts = <0x00 0x01 0xf01>;
> interrupt-parent = <0xfde8>;
> dma-coherent;
> iommus = <0xfde9 0x01>;
> };
>
> virtio@2000200 {
> compatible = "virtio,mmio";
> reg = <0x00 0x2000200 0x00 0x200>;
> interrupts = <0x00 0x02 0xf01>;
> interrupt-parent = <0xfde8>;
> dma-coherent;
> iommus = <0xfde9 0x01>;
> };
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
The patch looks fine.
> ---
> !!! This patch is based on non upstreamed yet “Virtio support for toolstack
> on Arm” V8 series which is on review now:
> https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@xxxxxxxxx/
With the patch added to the series it depends on: Reviewed-by: Anthony PERARD
<anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
