[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/console: do not drop serial output from the hardware domain
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Jun 2022 09:30:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W3ljZ3sBPZL/Y7cD5kvO4bPzF67C4pFjWnMt881L/ig=; b=NsUPk+wspOOU8kIPuaY9CZSyAiNKaJXOcmAZteik3VVT8fOy70CEIpmjm2WlMZ7SvjQC4QlWJLCYD1S96Esg1Es2qWAfTpesWcigYJC9hDQ+/5ZLYZ0U0FqLBAW/2JIC6d1wg8Ii80KpdbDwlMPfXyquh/e2h4HuMhjG+XTnlTV2TJrUjw1Bt38sv4omM4jEnrrXQjVCVH910IyRJa+LaRWACEE1N6hLRpMFuU5OAWX7///fAtPpugTbCmj4nZyTy/5tlhR+dJGI68n3NaEIQet1zrHe70s9fMmFhgSusOOApJmTspkemz73+L5kItmDGl5dOODtAkFlTBnTr4scKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EwvoXFttRnM0fF8kvXZe/Dk8BDzRsn9F7xYzoA0ugbgbek99FowxnpzM3a/2WR/sQmJCUtPH54Y8ap/K2LqX3vlb7IwXtg8lbJN8M7uiogrgCrRq1MHao+T+wg7VthZ5b/Su0s0Z1uQ+qVzT9BOO/5MNnyl20Ic+z09DBykmBIU/TE308ml2WZbAiQyBK4lltnJLgPbEQoXuBRn9m7RQqABQC5KVQa377efw95hizHztMZbQeUXmmIe2qfC1p8PFBOja/1mtRgEuQIu9TsyIXiDx2G1pTP57IIp/PO9ACIbtKzzeebJKsFNdzSbhpVW1PNq6H5v3b/MKHBw2wRYy3A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Jun 2022 07:30:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.06.2022 17:06, Roger Pau Monne wrote:
> Prevent dropping console output from the hardware domain, since it's
> likely important to have all the output if the boot fails without
> having to resort to sync_console (which also affects the output from
> other guests).
>
> Do so by pairing the console_serial_puts() with
> serial_{start,end}_log_everything(), so that no output is dropped.
While I can see the goal, why would Dom0 output be (effectively) more
important than Xen's own one (which isn't "forced")? And with this
aiming at boot output only, wouldn't you want to stop the overriding
once boot has completed (of which, if I'm not mistaken, we don't
really have any signal coming from Dom0)? And even during boot I'm
not convinced we'd want to let through everything, but perhaps just
Dom0's kernel messages?
I'm also a little puzzled by the sync_console argument: If boot
fails, other guests aren't really involved yet, are they?
Finally, what about (if such configured) output from a Xenstore
domain? That's kind of importantish as well, I'd say.
Jan
|
