Re: [PATCH] xen/arm: smpboot: Allocate the CPU sibling/core maps while preparing the CPU

[Michal Orzel <michal.orzel@xxxxxxx>]

On 14.06.2022 13:08, Julien Grall wrote:
>>> +    unsigned int rc = 0;
>> ... here you are setting rc to 0 even though it will be reassigned.
>> Furthermore, if rc is used only in case of CPU_UP_PREPARE, why not moving 
>> the definition there?
> 
> Because I forgot to replace "return NOTIFY_DONE;" with :
> 
> return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
That is what I thought.
With these fixes you can add my Rb.

> 
> In this case, we would need to initialize rc to 0 so it doesn't get used 
> initialized.
> 
> Cheers,
> 

Cheers,
Michal