[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 00/29] Toolstack build system improvement, toward non-recursive makefiles
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 17 Jun 2022 09:25:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uo+zauEWG+FJqJpZXcm9xKRVr1oloIRExHq6SRmPBzM=; b=JtdHHjG17E35VwN/PVPdSpFDR9U4Dp3O1wTq5+r+5Q6nhbDQm/dXHqAlUML0NNgIXCjoNOr+aa2AgV1s2QP/TbYUGQ90JZ7hFH3uk1mLCs9z22VqYKy/76sQjnaI5+6NaNQxPwJrsAXUXLT1bmygcYLzbYf/P3Egy99qTY+immgYnfM7y9ssin48d0n6rE3IKp4PCZBIlCBJI0g6gj74AfzGxlQ8CYyor6KBn34kBRdPoxFvfjsVHP8A9AejNMxFQlTZxyn+0TSqqPzk69lPDSeQ1xLqjUxt8PnUFflJj/kBpOtyUxxGSkZN9n2FFrJ1OxVzTBItvqkhV7iO7AnbHQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uo+zauEWG+FJqJpZXcm9xKRVr1oloIRExHq6SRmPBzM=; b=S3xjqnOl+VlKZu2b5Zuo9pTm4gaX4ca0dzlWoMV8vrGLn1mbD9ZSwdRztKzoB2XTqw4T8aN7CJiEUofRPncE5T9SafP1KM41LmLXlIQejZDm8NCA4ekYMFJ1Kixa2UR1183/w+o8gLwDqf61SeOlbBqfa4XcHV0S84/M5z7GdcqaH8xoSMeb8S/ssnFQD+KvdAEqgN3ZHiAId9qbtTd9A0Mg7xAFzbElFYBz0aPHLUhowZWh825JNlnhO9ILJvh0yRL5ywE6WJz/7Wc8BJfZkiMPJ4DC3BR7LPXrOm/+pB4wMhaSN/UCCDhQMyVKNKP8T/SJUTXg8J342LhJylMqPQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L+PNvsLutLS+cySQG699rlXYjGBWukGTQ1nKS1uCIYrtiBW5npeFJMnD5/YYWgjuPA4WyUW2G92G+PiMzjFY2Uhm0TN+r8uH/3Jsb7QcMUM3nK0IiMU2i62mYP2eyfkCu3YhV9Df8bdR+0czyRKUIO7aMpePJL9tTJLhL4G4cfkubYwp4UPM4Aduyq8U4D+cHeF9RLospSnEfzyCOtQdFckJx47Kch6I8NDwWpFvDesepPrKkwxSggzW+qLggJAVl3woa/9JuzQYxGjFEav0Qt8DFc1aiGncQbykDo3TlEAq39OvOZcp9EDB98HNS30ABAlGR/Jc3e1Q8ojryToldw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVzWtSrc1YIa/81IRctPhGtivlIkGvtUvx33immFWmfkiqKT05rdNbTWsjM3ZepxgJksfqHjOXG7LD62Nn/bukdZxsjq5ABlqMpfYc8KT+YaLPZezIzF/7/YgZZhnRV1oDsZjcH83z77weXb7i8TL10MYDBY7kRf8AMxACekW3GvcIJr/a2FRxYnejcT3VocMOPZUae0HO6EMxGoPIXEzYQ+KuyMNhETryy2c5zZ+hg7Y4381Mtgc3UvCcK/osjW+VsCEDES09s0WUEZH136jy6dXwSH8uU9HZPyTb1F9mhFQqVMH42Z6bxEbpPzipnf6U/b/ZJblhh7DlgDV/8c4Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 17 Jun 2022 09:25:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYKlphduUE0nKqEECOcZhD0sFLT61Stk8AgAFNXYA=
- Thread-topic: [XEN PATCH v2 00/29] Toolstack build system improvement, toward non-recursive makefiles
Hi Anthony,
> On 16 Jun 2022, at 14:32, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Hi,
>
> There's quite a few patch in this series that are reviewed and could be
> committed. The one reviewed don't depends on the other ones.
>
> The list I've gathered that I think are reviewed properly are:
>
> 11: tools/xenstore: Cleanup makefile
> 14: libs: rename LDUSELIBS to LDLIBS and use it instead of APPEND_LDFLAGS
> 15: libs: Remove need for *installlocal targets
> 16: libs,tools/include: Clean "clean" targets
> 17: libs: Rename $(SRCS-y) to $(OBJS-y)
> 18: libs/guest: rename ELF_OBJS to LIBELF_OBJS
> 19: libs/guest: rework CFLAGS
> 20: libs/store: use of -iquote instead of -I
> 21: libs/stat: Fix and rework python-bindings build
> 22: libs/stat: Fix and rework perl-binding build
> 24: stubdom: introduce xenlibs.mk
> 25: tools/libs: create Makefile.common to be used by stubdom build system
> 26: tools/xenstore: introduce Makefile.common to be used by stubdom
> 27: stubdom: build xenstore*-stubdom using new Makefile.common
> 28: stubdom: xenlibs linkfarm, ignore non-regular files
> 29: tools/ocaml: fix build dependency target
>
> (I didn't a run with them on our gitlab ci, and no build issue.)
If you do not mind resend a v3 with the remaining patches rebase on staging,
I can spend some time next week to test and review them.
Maybe you can also put in the fixes for the header check.
Cheers
Bertrand
|
