[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 6/9] xen/arm: introduce CDF_staticmem


  • To: Penny Zheng <Penny.Zheng@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 22 Jun 2022 11:12:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQ0EQNclJ8W/P8unN8Ie9ROq8PAoFEBXZZCngGJrLiM=; b=TY31veEGnvXjyWozDhOt6ldRS84HaFGde5bLhoa7RpuLfSYsxqiyqJ7+qVOmQOAnJZeAyTflycWyxrYVd63Hx78iMMTOgkZsRfsHgV2VSK7U3EhFnYegluAz3Go9G+sxmEcmS2wWqGIEralZ12C0CqUkxzWTuBvwxHOUXknSA1gIvbSvqh/OL0epL6V9+9oWWelkrvUx4ym/EAMJ/l5m+3G6ztzsBcugCBVhKF0y1tBCztxcoDQLmTvpWMnZQOKxV6QIFfGKv3I7YhjBJxa/1ggXisGBraozkjYSvz3Swqxk5R6zWYO4Bg/G9yzrKbxI1xtN+aio+xCaiUo0X/7niA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGLJ4kgItSiZavQc4RSQbuCValLcEVgmFMT5ZaqJEICu3DCsZ9+XDM/1j8EtLZNmAzDELenZr3ztYdrs7yLnFZbmk5hdANlQIWjToWBMdEH3UsoH7aV24gJaZxb4S7zndOHCpxbo40YdIeQP9fTPOwomf6I9msoDBbJSBqdoPSlydrb4olw1vHa9uM70GYHlBC2CRkRbMYIiwsMCdo12N6OFmcmo31N29MUbaIwdDjgqI1CDQH0szWMfbHcAULQM7g78iblpvjCL5qTeEFbnLeBOgfhiI184jByNujaUEjL4E66WzH+S21EpUTmRIVi1SD9+B39dRI+0otGxWDk96g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 22 Jun 2022 09:12:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.06.2022 04:44, Penny Zheng wrote:
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -35,6 +35,18 @@ void arch_get_domain_info(const struct domain *d,
>  /* Should domain memory be directly mapped? */
>  #define CDF_directmap            (1U << 1)
>  #endif
> +/* Is domain memory on static allocation? */
> +#ifdef CONFIG_STATIC_MEMORY
> +#define CDF_staticmem            (1U << 2)
> +#else
> +#define CDF_staticmem            0
> +#endif

With this do you really need ...

> +#ifdef CONFIG_STATIC_MEMORY
> +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem)
> +#else
> +#define is_domain_using_staticmem(d) ((void)(d), false)
> +#endif

... the #ifdef-ary here anymore?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.