[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/9] include/public: Use explicitly specified types
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Jun 2022 12:16:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=voXfmZ3qSmVDqG1NrDJqP3vlhexvEkCy5iaVtnIIr2o=; b=hBmkWBokU/6Ya6xafVjsCHG3Kk5ttProzsef319oV0am6USro8FZxClqFblWI/ly90dm2Xu4hTFrrWTcM7ZM9VDeb3ZdQ/gWSMxQNlMd8Zzl3sRCuspEfJOHnufjSSpZgNGYDAHj5YsWQYxu0USwo8aEGR6fgg3k7HQDI8asj1hvJYJNRzEEdfj43cOrjvIzY6DxriC8D5DE6oOQaTdo4FFtquGhPc36rAxOLhK1xt1IkKRHquF68tz4RDmu+vo1u6o3oaiwW1Lk+b9cyFs/GzlRp3NqoiNeDJ2LYfs9zMT3Wi4X5yOD1iIGC1xLQFbUOKFS3UG7kyr2+abXealLqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J9PHbBLnTnufEtHlDV03m+jQOKBcuolr6c/w0O/08QGygVfXB04/pG1Fqgd7YbVdK0d9m4D63JBeTd/TIUh+55e2tqV8NDAce6XDRpu1dHp6UuIGePpX9zy8sRiBnNltY7qt7cKynnWp4OwHimQmtHqCi7Dlccl57ZWzOwcDsBNDncklqKLVaUM2D3RC3dObLEz+m/B+t6MwsEroW7iQ3JZJ6ZnSTF8WI7rHEAwWPHCIcSqAmoapMEpvGcmXLQsEBZmlfwsiTE2R8IzppLLVGsdiQ8cmAFpfUqsXJt05F5PoQP7eMIVghqPVfI/Oganr8SLuKw8vdumjXQmTyRxyEQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 22 Jun 2022 10:16:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.06.2022 09:02, Michal Orzel wrote:
> --- a/xen/include/public/physdev.h
> +++ b/xen/include/public/physdev.h
> @@ -211,8 +211,8 @@ struct physdev_manage_pci_ext {
> /* IN */
> uint8_t bus;
> uint8_t devfn;
> - unsigned is_extfn;
> - unsigned is_virtfn;
> + unsigned int is_extfn;
> + unsigned int is_virtfn;
It is wrong for us to use unsigned (or unsigned int) here and in sysctl.h.
It should be uint32_t instead, and I think this is a great opportunity to
correct that mistake.
Jan
|
