[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2.1 1/4] build,include: rework shell script for headers++.chk
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Jun 2022 16:47:24 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZqdmGhm9cWS7wDJEELqzqMhbHsqthLU+rE1P1HskFfI=; b=PbX3I/fl0hruSTRhiUKGO5mOQQL2MYRJjMgk34THhCyh0zfut8rt7EwFDq0InhDeAykaLtPPHSkyIjEPi2eol5AhYe4YO09meMlpsNRmv8kO286a2UEu33wj6209dkSgw5C8FnUGj4txlSBnxYxrlH0NJ7vNHZqHm9e7Z1CYKpdQwDtkSHVWnsV5mXlqd1M3aM8z4qUisWjN/u+djnSRDkuTW69qNKTs72VyoxFyhRr7xIfqB2366rk5M+QQwB5N546gR7e7Opuvi4IjA+hsaBE9uFT1riuUgti5wchvFuTf3jw7TfpwWjZM/7qCffrAhEZTCIg79FaupMrwa6cbdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OjAMMM3FGYKxG5nNrx+wFgbETpazU/UcD4bDqHrxreEPX0nEGaeycw6pQIPotiF14RX8d6g70q4BQNZPYSb0aXGyKH2V9UvfvURcfcWhbtiejrJYSAgj1w/PeXEuT2Cn6i2sEpgcZyUd4DUCBmCMWiD+7nJulhEpXxW2FIF+zqcn7Kv2VkDtp/TVADxWKP9Pu1lfOhHEGrUy/ADGhyjHZ6Gr+bMSB3awp+oGTSBohzF7G0+DkIFuDU3ZIfZ9ovOWvzn1b+ehl65x/gBfGYxnI2uyQQAIxwJz5brcwXrEnuh44hNyLRlVk0dCBK6O1FuxR1W8N/1TdF4lXg4m9Depmg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 22 Jun 2022 14:47:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2022 14:35, Michal Orzel wrote:
> Hi Anthony,
>
> On 21.06.2022 12:11, Anthony PERARD wrote:
>> The command line generated for headers++.chk by make is quite long,
>> and in some environment it is too long. This issue have been seen in
>> Yocto build environment.
>>
>> Error messages:
>> make[9]: execvp: /bin/sh: Argument list too long
>> make[9]: *** [include/Makefile:181: include/headers++.chk] Error 127
>>
>> Rework so that we do the foreach loop in shell rather that make to
>> reduce the command line size by a lot. We also need a way to get
>> headers prerequisite for some public headers so we use a switch "case"
>> in shell to be able to do some simple pattern matching. Variables
>> alone in POSIX shell don't allow to work with associative array or
>> variables with "/".
>>
>> Also rework headers99.chk as it has a similar implementation, even if
>> with only two headers to check the command line isn't too long at the
>> moment.
>>
>> Reported-by: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
>> Fixes: 28e13c7f43 ("build: xen/include: use if_changed")
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> Tested-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Cheers,
> Michal
|
