[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] x86/xen: use clear_bss() for Xen PV guests
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Jun 2022 11:51:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cPkCWlh2g4+7fZKEVssqxY5bK56PP5KkWtPeMBrD6HY=; b=aWs67TC54fP+wfHpWULJzvk5Ehr7O1D58k+siXIicpbrZPCCRf7mJ+qrhYq/QEDFS48bDeM6+U/5s4IkUQcWk82J+a+2Yl94/9pxHBUXx6a+jOV/F2FXfmds4/4+UulMFIxLzzQZXJX+1Jat/NNV8kYa1FsJVOVKipcS0J6E/kEPy+bUwTeb/ySRTSzSiLfCdiNk49QlbCpR38ZUvB/mQOgbOyY5vQ+DMoU1QYn9plb37JpMQ6CNB1T1gsMEdhB52Zj1FoqmCQSMfb7QtV9cJX5aVvjK3EwTcmW8jXWz4IFnMj4hBWpFAgcmvS6Wk3A7WoM+PS5PNiPrD9/oHxJ8zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRH5NpRMrtMONiZ1XMBzLpTmL/ycHKKaOb5wO4TjNG5ztthbzpisad2IeutLdgqSMqS8m5cXiZnIy19RuGUKURLr5j4RU6IyeHzAZBK+uUyrUOeNPSFmIHrrwB88YYxD6/0hdIkGew2jnFIUaXA7Z0HSEHx+nJimzesczhbXiMaAIMn3HCmGjxzAjXKCqQirTvO9fAN1tNS/n8Grhj7RxvKblAgRvEqh0e1wf80mTY9MM92Cs8oODhWyArg4Dn9glxV2DtQVfKxtPx4OxczAgn2oNb1pO8G/q8FAemNOWXkuwkwVzBxEL/uOc3w22qlD19YmOCA+wIuIiJ8juk/lsw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Jun 2022 09:51:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.06.2022 11:46, Juergen Gross wrote:
> --- a/arch/x86/xen/enlighten_pv.c
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -1183,15 +1183,19 @@ static void __init xen_domu_set_legacy_features(void)
> extern void early_xen_iret_patch(void);
>
> /* First C function to be called on Xen boot */
> -asmlinkage __visible void __init xen_start_kernel(void)
> +asmlinkage __visible void __init xen_start_kernel(struct start_info *si)
> {
> struct physdev_set_iopl set_iopl;
> unsigned long initrd_start = 0;
> int rc;
>
> - if (!xen_start_info)
> + if (!si)
> return;
>
> + clear_bss();
As per subsequent observation, this shouldn't really be needed: The
hypervisor (or tool stack for DomU-s) already does so. While I guess
we want to keep it to be on the safe side, maybe worth a comment?
Jan
|
