[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] x86: annotate entry points with type and size


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 23 Jun 2022 13:47:13 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5BjUup+pWpLmGiOXVtu4EvW2I88EGKM/DoGMVSRMXMA=; b=GjnAjKH59BHNuf37Rhkyr0r42i/KOm1sAIImG1RMpYmIt78DXehgsa+wRm/vs+wuGm6aL7mKIQzzZFHMRD8T8gRfKAmcG51A3ZRNdbfGZg+f5tpdAkLPNC9cFReY2P/mO3pXowlNS53JeA8H98SKAlVssu5M5BJrF+nacxnfZgCMGOvpJHgpD6Tl6lhdq1qQQnY2St2SGbZq1d2RHy/bDNCwuCkEcEQWJo4AqeIyun410YUt9xVsXWgtkDdEpu3qsZeF8b7mhNUXPdZZ0iJ5RzVwkyYB4EeYYIVEMoz4BT9XBmlqpIC6RB0g6olaah/Z+wpYpz5bIk62wbBLpYLjxQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=llLr61od150z8QLEurreBm5PvY2U6s+PpYcrBXP2UNdUlmLYDq9IClSbFjiwrsGU2leV0RvoYHSlseYR13cUGM1dUty4bpG+kXUs13Ya7Dc0ygEA4okoHKY9EN/lHO/3oXnebglYCnvCy2ZI8T/d9rrDJT6AgiAvG8GIEq9X6kirtVSRqbFBm3zmDjyzSWH7YKYvW8E5gxaIReJUzvhOS1bOLDKiQjeSweOyYj+ojmitvUDOqgIkDEprzrnNI0Z8kM6Ip7FrI3txiDrF5c/2tnyTW2haxqrpVEt2oQJWR0GNWHSQz6z/VEslVN922+RgXSnNRTN3xCzv8Rk5271njA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 23 Jun 2022 11:47:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.04.2022 14:59, Jan Beulich wrote:
> On 14.04.2022 14:49, Andrew Cooper wrote:
>> On 12/04/2022 11:28, Jan Beulich wrote:
>>> Future gas versions will generate minimalistic Dwarf debug info for
>>> items annotated as functions and having their sizes specified [1].
>>> "Borrow" Arm's END() and ENDPROC() to avoid open-coding (and perhaps
>>> typo-ing) the respective directives.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>
>>> [1] 
>>> https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
>>
>> I'm conflicted by this change.
>>
>> You've clearly changed your mind since you rejected my patch introducing
>> this infrastructure and starting to use it.
> 
> Hmm, to be honest I don't recall me rejecting such work of yours.
> In fact I have always been in favor of properly typing symbols,
> where sensible and possible. I would therefore assume it was more
> the "how" than the "that" which I wasn't happy with. If you have
> a reference to the old thread to hand, I'd be interested in
> looking up what made me oppose back at the time.
> 
>> Given that it is a reoccurring bug with livepatching which has been in
>> need of fixing since 2018, I'd organised some work to port Linux's
>> linkage.h as something more likely to have been acceptable.
> 
> Taking what they've got would likely be fine as well. At least in
> a suitably stripped down manner (looking at their header they may
> have gone a little overboard with this).

Over two months have passed. I wonder whether I had misunderstood your
reply: I took it to mean an alternative patch or series would be
posted. In the absence of that and considering that you say that you
did want such annotations anyway, I wonder what it is that stands in
the way of these two patches making it in.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.