[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Jun 2022 14:53:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mcv18ceQNl32sTf34KHRDEcfxbOjbBVxPy7/ESfq/CI=; b=XGA8c9mvJSZaWbqBYWgealZjdeaScrF97dKJtarW6UpuObLT349tzsU+Gf3eC2MQaIV2cmfplnfFJ8RICRNLMmOEsZZmFd2mnYaNDIRQEXna4raJG9R7Lv83RSKzpksmobx8zjugmi4PuFDSexYx0VBjogHDioBvZ2kSXnUa3TpLYPXZJRB1F9lTXCoXCXVWnUU4LjbGIHzqapWVPLigyI7GCp2nLhySgpmVgX5HBL9eRzQVa6Ec/Fguh6X1R4fKRutto7OGgQYP6Ae7pg02eZbCgRGw7dpvjDcCFAT7jMygFY6hnOy33knR8EHH9D32PujuMirLI5/M73oprpE/vQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UvkbocTtxcaCVSeHg7oHtO4WMLlxBQl8MEjAMh/OSZ++DwG8lpYHhh2RPL7iOIy7C9llhgC+ebsMVnI8gYeH63oIi1BVeVF7If/lvYCbAxeW8smpO0ixxsupxlJU5MJZAQEML2kU3IpVlnQBdKyiOXZM3Vta5tEMmx1xfxw6hS3gzRI+bJmiR1EMFUVs1rkBqDudrk9BwaL25ZcIMFj0ruEub5mQHgi/KKoTHsFFrJcD5/kNzPfc+T6PBNfEg5V+Yl9nfJSngkzSva3bQWLdZkr2923W216OJIoMsmTy7tcTYD0BuvV2HLaX6zTK/cRco2DUmeS9bhfQvQNrhJLSHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jiamei Xie <jiamei.xie@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Jun 2022 12:54:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.06.2022 07:53, Wei Chen wrote:
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -1,6 +1,5 @@
> obj-$(CONFIG_ARM_32) += arm32/
> obj-$(CONFIG_ARM_64) += arm64/
> -obj-$(CONFIG_ARM_64) += efi/
> obj-$(CONFIG_ACPI) += acpi/
> obj-$(CONFIG_HAS_PCI) += pci/
> ifneq ($(CONFIG_NO_PLAT),y)
> @@ -20,6 +19,7 @@ obj-y += domain.o
> obj-y += domain_build.init.o
> obj-y += domctl.o
> obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
> +obj-y += efi/
> obj-y += gic.o
> obj-y += gic-v2.o
> obj-$(CONFIG_GICV3) += gic-v3.o
> --- a/xen/arch/arm/efi/Makefile
> +++ b/xen/arch/arm/efi/Makefile
> @@ -1,4 +1,12 @@
> include $(srctree)/common/efi/efi-common.mk
>
> +ifeq ($(CONFIG_ARM_EFI),y)
> obj-y += $(EFIOBJ-y)
> obj-$(CONFIG_ACPI) += efi-dom0.init.o
> +else
> +# Add stub.o to EFIOBJ-y to re-use the clean-files in
> +# efi-common.mk. Otherwise the link of stub.c in arm/efi
> +# will not be cleaned in "make clean".
> +EFIOBJ-y += stub.o
> +obj-y += stub.o
> +endif
This has caused
ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to
use 4-byte wchar_t; use of wchar_t values across objects may fail
for the 32-bit Arm build that I keep doing every once in a while, with
(if it matters) GNU ld 2.38. I guess you will want to consider building
all of Xen with -fshort-wchar, or to avoid building stub.c with that
option.
Jan
|
