[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen/common: device_tree: Fix MISRA C 2012 Rule 8.7 violation
Hi, On 22/06/2022 20:31, Stefano Stabellini wrote: On Wed, 22 Jun 2022, Xenia Ragiadakou wrote:The function __dt_n_size_cells() is referenced only in device_tree.c. Change the linkage of the function from external to internal by adding the storage-class specifier static to the function definition. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> Committed. Cheers, --- xen/common/device_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 0e8798bd24..6c9712ab7b 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -496,7 +496,7 @@ static int __dt_n_addr_cells(const struct dt_device_node *np, bool_t parent) return DT_ROOT_NODE_ADDR_CELLS_DEFAULT; }-int __dt_n_size_cells(const struct dt_device_node *np, bool_t parent)+static int __dt_n_size_cells(const struct dt_device_node *np, bool_t parent) { const __be32 *ip;--2.34.1 -- Julien Grall
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |