[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docs/misra: Add instructions for cppcheck
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 24 Jun 2022 12:18:14 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUzvdusQG3H6jh5zyg3/4GQJ9iuvCtDjcJ9QN0T5lqY=; b=Wuck4RWjttoUJGZ4zn5hXI6GsVLxRjCURubbyoyoyIZetLv3g7eMaQHMvC8g3Dh/3R/gD1KvLTKPjo7C57vq0XeJ92S3f6Olkh3+ydVrhpNkQrY910LFyvBXws5Dj7d3cW+kZn1Oq+OJK98wTpCslS2b2gY1Q6E4jKWBmEdYnTN+D2L14KJncbOgpN+yHuCX63rEmdAimFBW3gny2O6f4+vB/jdEzYI6t2dWAWEinte7kegOEmticJ0F0Jemda72OT9B94IMrc0P+cV8tz8GUkEgNtvwe1SlJaBDKxXYQcQUTWSvXWO9dw5IEgLByYmSpHuWW559rnfTp0BnQ8O5hg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUzvdusQG3H6jh5zyg3/4GQJ9iuvCtDjcJ9QN0T5lqY=; b=FcUEeYRJ9PnrpbSCk2G21sSFq3MM0DzQsZtPrkDo2TcTpU/PFo15MWKQeAhfnLyMgX/RXDwxaWvr6RIajDv1DqSD36EP8pxkGzTlL6oHdhhyQ24EDvwOWbc3lRO2+rozZPod4/qky8uPbhQF355+H+WAVWWNCLdoks4BMAb1A/X95MCehBM+3NstVF6C1okpxQESkEHk0p6UPmIF9qEUEGrXl1XgYOtH74M8nHhwR0kUZoF8hO9NKVx2qpwZIRczM2MT5GEqhv/I4o0ThjFbJmDw3Tngni+E/YcfC2HnmaKnk3nTfYRk6iAJzP6prThMPMCGgiheRfKUlTfdH3GvFw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FfdqDxtULSeDXKJO2RELwBvsKVQ+8HvDnJOogCDnYiDRpndI3zTC5xOuAXmQd055tukpSa/K7aNlPxQHMj0PfHWRWHRLFQ4xaiu74rEICXiNFfqcPZQlGA9HvzUcoGgm9XrgJkSPPvg43jZTnWtKLjsf52MYkqarayLNnOPnj8R635EmEI34l+Mm0o3Yd6AmDnNOk1+iyuTBoEQmRtT6Fqq9m2p4LadijgLoWp9CTCK+xNCdq4ldHVP6jFF26FpBtEM8j123EpgpXkLxwxM3ZMersabbBCgBovQL++iBnBNwfMPFOHgXN3xJMk+iha1WkUlhouzLmLtvfh45zNpANw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6rtpmnDnjoNcChquIMf+13qyUWG91H4vij0tMU1OwuHV0jem5gl1Qi2MtX82iyAEjHCoHD6Z1mQ2PMxlIwCee6PIakpgLLSMQFGTYKI5yBPMcKGFIJz6wVbR1haen2OAk0fRtz3Z54c5oQPjpM6JumLm8t3/bJCLlaRS0JFa0CVDo0Jr76a1EzoFoh2pnk/yfKNBNXkFWtGt1pKQPWBp+A55Y5hDgVaNoZsS8QfjwZtiYsl5kw3eHINEJcf806aHviCNw+nCiEBz9HwV5Uf18HneGKII9WyfA67s7MMcpf2EfrVdNx/8uFZpZ56TTBq2fzFeOj3pCooajjGgDdBfw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 24 Jun 2022 12:18:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh7iovubAjsqNDkKOdqYTdWMQia1eaYSAgAAFkYCAAAeUAIAAAtiA
- Thread-topic: [PATCH] docs/misra: Add instructions for cppcheck
Hi Julien,
> On 24 Jun 2022, at 13:08, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 24/06/2022 12:40, Bertrand Marquis wrote:
>> Hi Julien,
>
> Hi Bertrand,
>
>>> On 24 Jun 2022, at 12:20, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> Hi Luca,
>>>
>>> On 24/06/2022 11:53, Luca Fancellu wrote:
>>>> Add instructions on how to build cppcheck, the version currently used
>>>> and an example to use the cppcheck integration to run the analysis on
>>>> the Xen codebase
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>>> ---
>>>> docs/misra/cppcheck.txt | 66 +++++++++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 66 insertions(+)
>>>> create mode 100644 docs/misra/cppcheck.txt
>>>> diff --git a/docs/misra/cppcheck.txt b/docs/misra/cppcheck.txt
>>>> new file mode 100644
>>>> index 000000000000..4df0488794aa
>>>> --- /dev/null
>>>> +++ b/docs/misra/cppcheck.txt
>>>> @@ -0,0 +1,66 @@
>>>> +Cppcheck for Xen static and MISRA analysis
>>>> +==========================================
>>>> +
>>>> +Xen can be analysed for both static analysis problems and MISRA violation
>>>> using
>>>> +cppcheck, the open source tool allows the creation of a report with all
>>>> the
>>>> +findings. Xen has introduced the support in the Makefile so it's very
>>>> easy to
>>>> +use and in this document we can see how.
>>>> +
>>>> +First recommendation is to use exactly the same version in this page and
>>>> provide
>>>> +the same option to the build system, so that every Xen developer can
>>>> reproduce
>>>> +the same findings.
>>>
>>> I am not sure I agree. I think it is good that each developper use their
>>> own version (so long it is supported), so they may be able to find issues
>>> that may not appear with 2.7.
>> Right now the reality is not that great:
>> - 2.8 version of cppcheck has bugs and Misra checking is not working
>
> Can you be more specifics for "bugs". Is it Xen specific?
No it is not Xen specific (see [1] for more info)
>
> Also, what do you mean by MISRA checking is not working? Is this a regression
> or intentional?
It is a regression.
>
>> - older versions of cppcheck are generating wrong html or xml files
>
> That's fine to say we don't support cppcheck < 2.7 (we do that also for the
> compiler).
Ok
[1]
https://sourceforge.net/p/cppcheck/discussion/general/thread/bfc3ab6c41/?limit=25
Cheers
Bertrand
|
