[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Fri, 24 Jun 2022 19:16:33 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fU9f9et3mZnoAlvZRoVmIqFqPnyz/WIVKE/UkfGTTWI=; b=YmIpjVGZZndKzeJIf3/aHVAPoWBoDXcYRYf1B6cGqgqRJKYYhqxKBcHOrSDv9U+wv7a7P89Sf77cT5U0p/6rYFS0XJa55wuaHpipvDJWeetm+ZB4/zZW5fDCaVtLWD0rQFAxgBvqa3cbV17mhlT5qWufSn8bXu2UUGaId+8AXKbErxMQnMhyUAGgnOfGEhvdG5Y29mhqOBOZ7mrrCvn8FAO5Tjwadfdpba5ZicloPPcNQwrClXurwum2yuq3rhAx4kkubv77HxXFhYC+QS3i5RCvcSM004JhHhWueAJTo2F/EAlncZxgMVX4QH0JUvK3iyvDVlMO3kKqdwGzKWom9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nC8IpoQS1nBySeh+yF8gvjCJ1azFEZ5r0y/YF3TvFPLytqxIl3RHqGIeKu9PzA2s7Plel0uRe5CgoQH4N+bUjVw2iGgFXfJ3UIEJoJxWQJEIOiqjnCfr2Qf5gQ2NbUNgvUIRoPh9pcBSaZbsvjlHA7t32ToJ96DIBWPnfanFr9aqgDewR4z5AhkcZ6yJkqThH9FhvlQrS/hOV/VOd4zJ6nFPoM63ixMVl/woY9Z5wYaSzbiFAGHdRjmyvtuJtfajs4iIcHNM8YZE8OV2+s6sF6AEQ5pDx6Xo3aTBZFMz/KJ1GU0pGZ+Y4J+pHVtNZRTE+bhgph7EXJyZo94NBjkHrg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>
- Delivery-date: Fri, 24 Jun 2022 19:16:50 +0000
- Ironport-data: A9a23:ujcw3a5xM24ubgxAkIiv0AxRtM7GchMFZxGqfqrLsTDasI4TYg02e lBvGjDRZK7OJyCgZYg1O70CxjpU75OGytRrGwJv/ChgQi9HoJHJC9rAchmrMnKcdJ2TFx5tt JsTYYSZcpFtEnGH90qnPuaw/HVx2PzSHuWiAeOeUswdqXeIbQ944f40s7Jp0uaE+OSEPj5hm e8eguWCaFP40DQraj5Juvvc+EM/7K2s4mpIt1UwPv1B7AfTyihJAMoTK5/qIiqjSOG4PAIbq 8Uvbl2d1jmEl/v4Ior9yt4XSmVTHviKe1LmZkN+A8BOuDAbzsAJ+vt9ZaB0hXt/0W3TxYgvk okV7vRcdC9yVkHysLVFO/VnO3kW0Z1uoNcr9lDm7KR/Z2WfG5fd660G4HMeZOX0yc4uaY16z tQKKShlU/y2r7neLIRX6AVbrp9LwMHDZOvzs5z7pN3TJa5OrZvrG80m6TLEtduZaw8n8fv2P qIkhTRTgBvoSAVyNwkoT78FjPqqxVvjamdxhGq4uv9ii4TT5FQZPLnFFvPwI4XPbuIM20GSq yTB4njzBQwcOJqH0z2Z/3mwh+jJ2yTmRIYVE77+/flv6LGR7jVLVFtKCh3m/7/g1B7Wt9F3c iT4/gIBoK8o+0HtYsT7WxSgiHWFogQdS5xbFOhSBASllfaPvFrIWjhsojhpV+YIiPYvfgQQ7 HiKvPLbJwV/vOKbcCfInluThXboUcQPFkcAbyIZSQoO4/H4vZo+yBnIS75LAKOzy9H4Bzz06 zSLtzQlwaUei9YR0Ke29kyBhCijzrDWSiYl6wORWXiqhitlZYuNd4Gur1/B4p59wJ2xS1CAu D0PnJGY5eVXVJWVznXTEKMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCNPAfj16ZYyjy8ZXdKA==
- Ironport-hdrordr: A9a23:keUu9axFZB9UF3yxQOWbKrPxgOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SETUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZHN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUezpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZrcI5p4dYyxY/ouW3fRYzWTFcFcsnq5zXQISdSUmRUXeR /30lAd1opImjXslyqO0GbQMkHboUoTAjnZuBClaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77WzADnfzJmNXftrdmwtcrQc/tQ0obWIlUs4ZkaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbNfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2HfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPIcFyZMj8a 6xJ2+wdVRCD34GJff+rKGjqCq9MVlVdQ6duf129tx+pqD2QqbtPGmKVE0u+vHQ1skiPg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX7O+5hV+aChvnbkCC5GJvwBDI6a1gI+MA
- Thread-topic: [PATCH 1/2] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change()
> On 9 Dec 2021, at 11:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> In preparation for reactivating the presently dead 2M page path of the
> function,
> - also deal with the case of replacing an L1 page table all in one go,
> - pull common checks out of the switch(). This includes extending a
> _PAGE_PRESENT check to L1 as well, which presumably was deemed
> redundant with p2m_is_valid() || p2m_is_grant(), but I think we are
> better off being explicit in all cases,
> - replace a p2m_is_ram() check in the 2M case by an explicit
> _PAGE_PRESENT one, to make more obvious that the subsequent
> l1e_get_mfn() actually retrieves something that is actually an MFN.
Each of these changes requires careful checking to make sure there aren’t any
bugs introduced. I’d feel much more comfortable giving an R-b of they were
broken out into separate patches.
-George
Attachment:
signature.asc
Description: Message signed with OpenPGP
|
