Re: [PATCH] docs/misra: Add instructions for cppcheck

[Luca Fancellu <Luca.Fancellu@xxxxxxx>]

> On 24 Jun 2022, at 18:25, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi Luca,
> 
> On 24/06/2022 14:34, Luca Fancellu wrote:
>>> On 24 Jun 2022, at 13:17, Julien Grall <julien@xxxxxxx> wrote:
>> I would keep the section about compiling cppcheck since many recent distro 
>> doesn’t provide cppcheck >=2.7 yet (and 2.8 is broken),
>> If you agree with it.
> 
> It depends on the content of the section. If the content duplicates the 
> cppcheck README then no. If this is just to point to the cppcheck README, 
> then I am OK with that.
> 

Hi Julien,

Sorry for the late reply, this would be my changes, would you agree on them?

Cppcheck for Xen static and MISRA analysis
==========================================

Xen can be analysed for both static analysis problems and MISRA violation using
cppcheck, the open source tool allows the creation of a report with all the
findings. Xen has introduced the support in the Makefile so it's very easy to
use and in this document we can see how.

The minimum version required for cppcheck is 2.7. Note that at the time of
writing (June 2022), the version 2.8 is known to be broken [1].

Install cppcheck on the system
==============================

Cppcheck can be retrieved from the github repository or by downloading the
tarball, the version tested so far is the 2.7:

 - https://github.com/danmar/cppcheck/tree/2.7
 - https://github.com/danmar/cppcheck/archive/2.7.tar.gz

To compile and install it, the complete command line can be found in readme.md,
section "GNU make", please add the "install" target to that line and use every
argument as it is in the documentation of the tool, so that every Xen developer
following this page can reproduce the same findings.

This will compile and install cppcheck in /usr/bin and all the cppcheck config
files and addons will be installed in /usr/share/cppcheck folder, please modify
that path in FILESDIR and CFGDIR if it's not convinient for your system.

If you don't want to overwrite a possible cppcheck binary installed in your
system, you can omit the "install" target, FILESDIR, CFGDIR and cppcheck will be
just compiled and the binaries will be available in the same folder.
If you choose to do that, later in this page it's explained how to use a local
installation of cppcheck for the Xen analysis.

Dependencies are listed in the readme.md of the project repository.

[ leaving Use cppcheck to analyse Xen as it is ]
[…]

[1] 
https://sourceforge.net/p/cppcheck/discussion/general/thread/bfc3ab6c41/?limit=25


Cheers,
Luca