[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix compilation error with gcc13
- To: Charles Arnold <carnold@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Jun 2022 08:29:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogcTZpmZMCofwVYSyIvnrE9+Xp50lIbVwPYp8yzvc0g=; b=eOw+i6+qfym8fNZJNG3sh5RfrvPCsWhBYb3U5igkvco5LqmGu+gEnPKiWL3T4oqOwTRvLaY+pTtHc/huqDeM0qN0cl/BamDNE9WuhYd8lt/OmUUi/3sqcclFWuczQgt2s/WSZ18W1dk20q6VIeBG9mqsVq7zTOreAQO8YipChB5EKuHXoG4v4fbhEvzLZUghTjx+0hs3uTxyK+HT4Vm/5R4jkz0an6AIKc3EJU5Y7ptZWBeNs/SdAau9z9oQwlF3qSkBt3pdjDNRH+kOxLuTbytczYdBrBGP/Hm4AP+x/8N3M27HKSemlZwBJwNqgjekvf0IF8EmeDVDCmDIODdB4w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhpZ/qMHIzmCzTZVeVWM6zSb8O3JakJB0CK6IW0ekbaZ4IAen2aYkoeCiQsHJXcULc4ak9B/d/yonKV28TWgSTnLNGnCsE757RM1JEzjZx6NRQhKxrUoWwC3GKKsvCHekqmMJ6C5TEQVc9kHidw6m/nFKWD7nYFs562Fs+xt2BSiZ4p8jWS/1jsMox9HFO38Ttzyr0QcdV/qIiB6R0YQeJT/W/4seF8f/IzxcfjffoaWGvorRmAx5bEVBVvUWSScUDL151Iw1X214OYr4PimxH/6EErwSXv8Ri3pqgQPbtqMFW1ldIveKV5Xxp2WasdNlq4OkA0oZj4y02TmPagw/g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 29 Jun 2022 06:29:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
(Cc-ing maintainers / reviewers)
On 28.06.2022 18:09, Charles Arnold wrote:
> From 359f490021e69220313ca8bd2981bad4fcfea0db Mon Sep 17 00:00:00 2001
> From: Charles Arnold <carnold@xxxxxxxx>
> Date: Tue, 28 Jun 2022 09:55:28 -0600
> Subject: Fix compilation error with gcc13.
>
> xc_psr.c:161:5: error: conflicting types for 'xc_psr_cmt_get_data'
> due to enum/integer mismatch;
>
> Signed-off-by: Charles Arnold <carnold@xxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
The subject would benefit from having a "libxc: " prefix, to know at
the first glance which component is being touched.
> --- a/tools/include/xenctrl.h
> +++ b/tools/include/xenctrl.h
> @@ -2520,7 +2520,7 @@ int xc_psr_cmt_get_l3_event_mask(xc_interface
> *xch, uint32_t *event_mask);
> int xc_psr_cmt_get_l3_cache_size(xc_interface *xch, uint32_t cpu,
> uint32_t *l3_cache_size);
> int xc_psr_cmt_get_data(xc_interface *xch, uint32_t rmid, uint32_t cpu,
> - uint32_t psr_cmt_type, uint64_t *monitor_data,
> + xc_psr_cmt_type type, uint64_t *monitor_data,
> uint64_t *tsc);
> int xc_psr_cmt_enabled(xc_interface *xch);
>
The patch looks slightly garbled, reminding me of how things looked
for me before I adjusted TB configuration accordingly. I'd be fine
hand-editing the patch while committing, if no other need arises for
a v2 (and of course once a maintainer ack has been provided).
Jan
|
