[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] x86: fix brk area initialization
- To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 29 Jun 2022 13:17:52 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HDQXZKqaw0A5rOXZ5xAzN6hKpLvNQis5UWbnEKxVxZw=; b=CCaD8LpBunRfMcRYCQlcOnN4gg2q/sWGOfQnVPQw4znLd93n92qsYfQ+XKtg4gehq4OwIOhsR6uK0Z7djU75qbYSd3uTBu7iFwQ4FQftXaA17dt58DI3dYrNqrk7tjsHT4hsiJUg3VBYTatEiP/nn8F8z4ja6M/so/Wer9/XjnFcr6ZfesW5nou7Zc92RFR+UVchrfc2ScyXrp2QglzbjTczY8d75aPuSBwa5OnB0S16dJf/4VQbQxmlY9LTnIDHlhfRhmadgaLFvqF4VDLjScUxxlmDgk/nZXP2JgMf9iVMYGLvKDoTAS6af3a0xyu8rCVM8wcEpBsE+nBF1PEuHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BoK3l5LLRsC6XB+uUop6+cG4hT2RecshHNsyYQcMDxPZAPLeBVm1/hqpJ1jnev+/YPQ6TzMHBHCkvo422ujrGO5ISb5/57K61SlfGUT0eX0qgyUsjzY1l4Ycrx+dz1DkcqyZ/Lx/gv9AqRsgflfRVETA1mRhxXxECHWMMcqqg+7JKV8B+8lql9i65gWl6ISf1CoNZPtwI0MHQ6ZPWlpfeayzG0AvxOn0pblN/YDu8Bx8d2E9d1GQGwGHMQU0F5ihqBrFo01j7uAvUQwIDTIaWdfcCzvprK163agkWNtL+/fUYeP3XuXx8hHqv5/eGMCz0Wur1QYgO8kcJW6AjOqUSw==
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, regressions@xxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 Jun 2022 17:18:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/29/22 10:10 AM, Juergen Gross wrote:
On 23.06.22 11:46, Juergen Gross wrote:
The brk area needs to be zeroed initially, like the .bss section.
At the same time its memory should be covered by the ELF program
headers.
Juergen Gross (3):
x86/xen: use clear_bss() for Xen PV guests
x86: fix setup of brk area
x86: fix .brk attribute in linker script
arch/x86/include/asm/setup.h | 3 +++
arch/x86/kernel/head64.c | 4 +++-
arch/x86/kernel/vmlinux.lds.S | 2 +-
arch/x86/xen/enlighten_pv.c | 8 ++++++--
arch/x86/xen/xen-head.S | 10 +---------
5 files changed, 14 insertions(+), 13 deletions(-)
Could I please have some feedback? This series is fixing a major
regression regarding running as Xen PV guest (depending on kernel
configuration system will crash very early).
#regzbot ^introduced e32683c6f7d2
I don't think you need this for Xen bits as Jan had already reviewed it but in
case you do
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
|
