[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 1 Jul 2022 05:15:29 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GVwCWXc1+TSNoacnkpf/IEWCE7xaUXwTOiE4rGFpa9E=; b=gU82rU0BJ0+WcNWex7si6ndIYv1MbkJQW7rloDSQvDLwwp1zSfQcLsLUih2W4tX7+lKRUHCHCEB0HjXFAbCAtUyF8ZBQbhAO+QUr0p+aWBztjIAZCLsd/O41sYmzEuWHG7rQIfrk0wZ1L7ICIMWqo6KSoktyvxXCnoKDHKccKspQVK0YBtU1tvZOSVMEWLxFScTzODu5//VwvHjmX4r8I70v5rE3EW8Ac6bjakpIDfdERWzGdcf0NiMT3lYXZqgFhAnFERCN5g6ZE6r+MJ9m53ZmqM+GCUHeox5qhi1WCzS2+0b51/kd2BgNcJBiLIIqoGHTDPu9wCLBfXI2w5ROWQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GVwCWXc1+TSNoacnkpf/IEWCE7xaUXwTOiE4rGFpa9E=; b=nOIBFdunQOO0TX5f8h/4wn8reHZKQ1CyZ/7b2p0dWLgzlEC/zRiP2AxVTKTltKOsxXTKDJN9JN70yNRwni2BenzB057+nSejaZJS8FRul991M9Y6La1dg/wT/u8IMfCDhoLF20fFpRET7ZvXmyP80iwP6Wajt0hrO5DATyIz0X1nxcZIwNvcXiIB9eEAOIK9FoIS02Qmj/VSNH7WhX4V9UWycQT5d21XRhQEHPBHNDJG2EGYeTO7bbjzZD1swP40Avkg7hhDmGQCNBFfEXcWOfzwKQwm6fbxU0uKxq+zepY5CYKU4MxB26nwU1NuJ/rzb3gyD7srGpC97CYjmajvRQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=h/LMnun09YY7f83eiTxVCgUPKCeG+hloqAakOWV2lbvEwtkzBJoh8vocxGgCw4T+eI45DD5A4nvoxUHPAhYRekm5+60JzlNKpciKG1PEDUaJrQar92k+163YljKJYffNJBtdyWe1r7cDzN1zJ9kkWzbcyL7fknNg6CGpK4DfxAM31fcTroB78GmJSaQ9RqHA1vBuA4G10E48ol9f7skHHbeBEHICfitCWaIJSjrla9+QhV2Stb5Pw8mQF9YP1BOKdA8R4xEdX65U72ztJ5XZdSYiIDjriJWVagdgu6qBgINAoWn1OcsMapA3oFd7EWeAMK1QEa03AjebpwNShNtRVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BN5jo6z5u6jGejB/WPplZ5lWEFgQjuXnWSZQtio0bZ6ikXBrDUW9kCVNDoyP/Onygnn0eWwtz3NxRPgxEsu4g2k8EisgiXYtDeDXboAZfshWCbA09cgn1oOhcMw3HzCLzOecTMlgqAAruEwD/v5f0wXmzzea9a5YVmP6Wsu9UUzuntal5tnBJXb/pp3qveWC53m8z+CqJGvsmDul4uu3woHVDKjnfhjJ7eGSSFK8yguRlRIVpB7ZqS6m+H/usqqupcOfu7eJn81Uc+5Gvx2JAZGZTKTj5aB0WwboYaAcl3O5T4Gl812eKRqMBalrITKyl/1MjKhdKR9OF/1siN9DoA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 01 Jul 2022 05:15:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYjLCT8ll1pspHXU2Irp2zQF5YmK1ox2KQgAAxoACAAABVAA==
- Thread-topic: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end
Hi Juergen,
> -----Original Message-----
> On 01.07.22 04:19, Henry Wang wrote:
> > Hi Julien,
> >
> >> -----Original Message-----
> >> Subject: [PATCH v3] public/io: xs_wire: Document that new errors should
> be
> >> added at the end
> >>
> >> From: Julien Grall <jgrall@xxxxxxxxxx>
> >>
> >> Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors.
> >>
> >> To be conservative, mandate that new errors should be added at the end
> >> of the array.
> >>
> >> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > While the change is looking good, just FYI there is an "ERROR" section in
> > /xen/docs/misc/xenstore.txt that points to the io/xs_wire.h. You may
> > want to add something there (that depends on your own taste :)) )
>
> This documentation is meant for users of Xenstore, not for how to modify
> it. I think the comment is all what should be added.
Ok sure, thanks for the information. Then I think this patch is perfect.
Kind regards,
Henry
>
>
> Juergen
|
