[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building
- To: Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Mon, 4 Jul 2022 04:34:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5SAIXMR8oTPy/o32JQNbPM2q6ExtaEbHcFkRFG207o=; b=H7TP0VNwYFzgDdgARNofnNqQt7RDUnDqmSMm6g5ZN/R00Z0+WEr3eJHwKZ7VLO6DvqmUQ6H0Nsp8zSCW72TmFSl2mTDnW29ZR170vSXc1DBCA64VXOuvXonAHOfMl+8co6nLmLOdAcAPFJHwQNhKNg51OVTD7EUzfuJP8TURRHGMFLI2BBVNYmmRF5yqrIKa5Y3i/tB4TcMU3jgS5wrlQ6MEi2arZwfiThykXOAnZ/XSAJPamtRtEfizkaACcCsgxTcVizKO5+N4Uf+y0b/DnGFjYn23ZdyU2p7BcNub+C9AmTFoamRo3CeUBgsaoUgSg9IF8vLGzoMlKkeF0Y6hdg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5SAIXMR8oTPy/o32JQNbPM2q6ExtaEbHcFkRFG207o=; b=cykm1/u9Ykipo4OKrJipNd7PKPZzJvXv4012AYy4+gVeKTFOKnZjo9urKj8rtULT5INZz2a3Eb9bbZTy1pK4lbv4OSIoW/tC+GOL6Mi7ZKHsZF+y0BrmIRwDe+1pvN4h/p4wGD6vr4siJF1tL0gNWFHXS/+v5WZdPuczGDsVICbJz5jT/XFvXfJHC7+TbM16U+4RuQlCTcBd9Rt4W+LzzDGcIe5ZHjPwHy5tn9grbD/HNTPPpqiKa+DPyHLMUcJn+8LG9ploa3GGTsZGxv/W5Z2tz6DeZ7uAv3yInBnl0DDiUJ81KfKhxIynh1QnbbBFHSzsuV3BWJL9KAe3QClSlQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=k9zHoBNQcio84mWleki7Ff/S9CrRV96fB8CefvvtFrcbvl7/fumiSfDNg9S7dJ0c9vSrLZp7pUAV8riUYUasxozDUclcetDfr1KezNHk+e/u7POLJlKBtqhmf1DlH+w1W8Ayyj4N1jlnG00lcBmXc7tp582Eg6gFeE+HotVOKJRML0eUwmZV7k7RHEmzS2xB/u0k5s/u5zUupgT2YMCKsQs59ooVrMxyzzSmLdxGjCf5JJba4MLzmQ+S/W6xaOBxuSy+mYbUNdHW+txQLJ2zps6sGqqsuGEvkdx3H3u1wtWvToAJvRPgt+1dvO6L2N4gtXRe+LQ0Asr/dFtscgqrTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azwJGVLI9LPaZFSCMVDgUVVvMSx2w2XsrPj7GzZdCRwyLbGM5X7Fbb62qIjs4CQ8GE7hslEkMDxvzZO9yfHqecdESBNn8quVREskg7KKxHHqipnFpcF6E1X9TrOEWw0YwMlzJbfyz7GGcDT/byRzC8kJ7fcKe8IM6zP5zG4m5DOPWec1jmOCAQHI4kIFw/UPYKYa2JqdEA0ZfiIlEiGxOJ5KmTy2ywpLWhykecWMOhujWBcCiV1VIb4Mz1H0KWmaCPBinHw4iy0gcIRQn0wG49Qwz0xJNTY3xoRB8GzYzar2J8oWPqQNOOOvIxOamXFFwPK11UPqKGJTg35qxXW1eA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 04 Jul 2022 04:35:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYjTNsIdi3A5iEXkONabS+bAWlKK1pUfqAgAAoDoCABCcJQA==
- Thread-topic: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2022年7月1日 20:58
> To: Jan Beulich <jbeulich@xxxxxxxx>; Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>; Bertrand Marquis
> <Bertrand.Marquis@xxxxxxx>; Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32
> building
>
>
>
> On 01/07/2022 11:34, Jan Beulich wrote:
> >> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> >> ---
> >> xen/arch/arm/efi/Makefile | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile
> >> index dffe72e589..b06fb96c1f 100644
> >> --- a/xen/arch/arm/efi/Makefile
> >> +++ b/xen/arch/arm/efi/Makefile
> >> @@ -1,5 +1,9 @@
> >> include $(srctree)/common/efi/efi-common.mk
> >>
> >> +ifeq ($(CONFIG_ARM_32),y)
> >> +CFLAGS-y += -fno-short-wchar
> >> +endif
> >
> > Simply
> >
> > CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar
> >
> > ? But, as suggested, perhaps further
> >
> > $(obj)/stub.o: CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar
> >
> > to make sure we'd notice any other uses / issues here. After all it
> > is - at least in theory - possible that Arm32 would also gain EFI
> > support, and then it would be a problem if the other ("real") files
> > were compiled that way (albeit I think the issue would be easily
> > noticeable, as I don't think things would build that way).
>
> Instead of CONFIG_ARM_32, I would use CONFIG_ARM_EFI. So this would also
> work if we want to disable EFI on arm64 or enable on arm32.
>
We have already used CONFIG_ARM_EFI to distinguish EFI objects and
stub objects for Arm, so maybe we just need to add
"$(obj)/stub.o: CFLAGS-y += -fno-short-wchar" to:
ifeq ($(CONFIG_ARM_EFI),y)
..
else
...
$(obj)/stub.o: CFLAGS-y += -fno-short-wchar
obj-y += stub.o
endif
Thanks,
Wei Chen
> Cheers,
>
> --
> Julien Grall
|
