[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 4 Jul 2022 12:35:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WwVmXhjQUYqEw3iucK0gBCn2de2fsddfDRRY3Msm62Q=; b=MqSDkpd2FKE1KekZZ70q1wqa6tjAouOVpRPG+QAHZgywq5R5bxr02+E+xaBhrbFH4Ft9wA12RjojjNbtuAsToX2MZmEGi30NL86/BVuH0bQKfAMg8LuzuUEa1raSsO2A2nNvfb2+FwKGOVlhAvcG+mVCwO1/GkXcbZz2/679XT72NnFDVVcJOSQq0hU3WF0xKRE6cVZFUwQGKqKqa4Vn1j7/hIFSM3kJMbr6xLJHImEtocoCJcF2wDGZOYkhPMwxRpOVK6jI3A9mJ51uyGLQkmxYsW/PIpOFWjhSVTVAx4nu+FMOvg+AhbJkjhwLRG88f4uORlMBKpABpXyK3uUFPA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WwVmXhjQUYqEw3iucK0gBCn2de2fsddfDRRY3Msm62Q=; b=KyCnERSVSno58Smqr97lUPunjmujmzfOvBaCKBJHiDttuyN/8EwFU7VxdJZp2EgNPtTYoItWxt9RZSBBDEqYqBKTjFfd8U6pKibF6Prz1ZTyZmZ6l+G+yGmbJonNE5VtSoRdnxDZx3gmdUiLhuixjwekvJdwXeDO/ztAtOvM1TkXuFUd4Q6/NHPAJSIVz8ne2ch6MVUZPtnXH/hF92VEF7nIJnNPFPkYkcJKFxWnCe3n7QHi5HMa76breYWRtVLVlpP6wPzJSMDLlMWfbBN/aMTKNMuUiU/UAsIBAg1CSyBEhBshL89yXQLlAbEEaK5AgPEYbdACtUEA2f1GDRy80A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=C8Kh2iuDrVE+esE6djcoOBUElGQdYRBDWajcLOqOLJmU3zOevMi/t5dBY2pBGtXhpjRI5xEjfRSV022duWGVFu0DD1zOif+zAnUxKovr2Exz6cbbv23BNfMH23+6y3fuG08tLOxO1oxln5CSKrLc+9yP5QraKYJ7TkkfYKU2VuUDOxeENexYfa1pNpxsdc7xCYBH1xoBMPhHAcgzIYsY2UK7uJvlT0ciQrdCrehREND4INJOfOCqqEiqz0gIZWChBj9Rcx2osPjc6cqGFghBNGMTPxYVX2JZCA4VIhJMUlDOQ5dMUMkkF5am1ElWwyHLRB43BP3VMnfHW83fMnFErA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiCcCnGv+y8rLAshEi0QkRwsiyASaINd9TXTgj39ulCcwyA8YvaPsffObkebwnT1Nrh9MVxse8WYDEMgKMbL3WqEsaCLjEOVvg8Yx/gm2+HKZOXG1fNoSDt0dwh66m5ezwn9ECw+zheCsXPLn/8aITwnjwllDL1ZWv4dVftxmPVsr2ovCA5f3BJi3VNz/yEkJ3JnaXPVK/Y26vuHNOH/lGvYKjoT1BC6jRCs9bzV9uSvX6z5O3j/FDLBigLMwn83HCGF9KFqL9KWd/ASU3MzevnWw/iv99To86vZbsNSPYbL5PCIXasjd0Kfex8/FICrdrZo+Ddj5UERtg9X7mqDFA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 04 Jul 2022 12:36:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh6p2Vro/QJFr+UKIGJC/olafua1uNcwA
- Thread-topic: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()
Hi Julien,
> On 24 Jun 2022, at 10:11, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Both destroy_xen_mappings() and modify_xen_mappings() will take in
> parameter a range [start, end[. Both end should be page aligned.
>
> Add extra ASSERT() to ensure start and end are page aligned. Take the
> opportunity to rename 'v' to 's' to be consistent with the other helper.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
With the prototype updated in mm.h as suggested by Michal:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/mm.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 0607c65f95cd..20733afebce4 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1371,14 +1371,18 @@ int populate_pt_range(unsigned long virt, unsigned
> long nr_mfns)
> return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
> }
>
> -int destroy_xen_mappings(unsigned long v, unsigned long e)
> +int destroy_xen_mappings(unsigned long s, unsigned long e)
> {
> - ASSERT(v <= e);
> - return xen_pt_update(v, INVALID_MFN, (e - v) >> PAGE_SHIFT, 0);
> + ASSERT(IS_ALIGNED(s, PAGE_SIZE));
> + ASSERT(IS_ALIGNED(e, PAGE_SIZE));
> + ASSERT(s <= e);
> + return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0);
> }
>
> int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags)
> {
> + ASSERT(IS_ALIGNED(s, PAGE_SIZE));
> + ASSERT(IS_ALIGNED(e, PAGE_SIZE));
> ASSERT(s <= e);
> return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags);
> }
> --
> 2.32.0
>
|
