[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 5 Jul 2022 12:34:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HXyJhOCr6VrkrYsOXyERShNoJHw+wd2rE9vtb2Re0Vk=; b=EW9WaAx25etSEZdJiWed67ewgg5MnhaG83FhmeonEzDJv7I4Lu6e6MyUJoD8JV4Ip+CAY4TIKO7PoGxGnxKSAlxjMxt3VbQZGsIdfKvROhuM+U5nVnNdnrMThZF3NE44wl1E2rJnPb77m0OxIzDFUjtdzggb7fFOZiiqY3isFw3m1VjhxftXnNX/pAUPB2gmjvvxvZhCHp9kG8RiEXkyJnsw9YJupPRjYhXHf9MqxzGV3QUGvp5sNKTXhsf6iTWDUbsHiRQOwnSecmcPEIgGBrVgzhxbasby1p5bEjSL5L/SD73P5R2cHghBL4l4wBMBD5s2kWOywmwoZu8oh8/Xog==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HXyJhOCr6VrkrYsOXyERShNoJHw+wd2rE9vtb2Re0Vk=; b=ZtPeVEEkGLUZNcN3P9Y/uRmTR7SC4/NERAAYa+oiWsy6aRveuuJcULb877VsTfxakSZXrE3s5R7NNaKRDMDs7NOYoP+MvFhERB5QfAHNV52Q49z4+B4Xk0Evklo+mCNWHaDpEx+P0IYzFVbvU34keBz1pXmZgNM+VY6sxTLun98YdcOIFo7T5pX4g6HEEvimCZatKh1bNXgCY1sBHoXHBDlddjS0HGPxh2cM9KYHmAHmcLgGp/tUXaKCXf3sXkuKMFq7OYGvS+4Vx/cL/kA2SUSJNq9S8reqeXZoER5vp29TtgHUebOL50WBjKRbTiT4CUK/Yr6hSO40RuxrmlNHdQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IVXsSH3+AViOK5FdxuDhS5Aqk217lPW9B7Qjgk4K5/r0S1tbQxO2mzqaMp4QFGMb/lVMko47S484Dan76mRJqWRyqogkXujvnP+LWuUPmDWeYNgQG/V+JQptXvX7Q7ehMwnPcYupU+rTQMDrl7dr2PgotRV5Z20tgH5VNTvGQ5EnDL0LxB0rOigeR0MQ5r+7Ebwgx13x7G4QaYNrecXIWgq0fQUjzD+SAOxrnnIz3sCRIAQvOTc3LHGh2GC9hh3aDa2Uf6ClzTiweuDKWWuYDdrVwDB0F4ZkjbkVSAORBxXya0z1/Llz8J1tm7TH+xQWhMAwUstI0qgVVzearipUGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVmWcMXM56XTlxayB4wX4OFlVbVIbGjvxH/AqGEQGBjbfhY80MB4NBDvomalSZFmSu2K0Gl62Qb8AFxKlbHTuz/UBYHX3q1I0F0tbM8iqaKIm+HYJb8uYu7XuYeDYA2RT29XHZQDzzS3xfx7JBskB3jLl3Tud/4gTSrnlY4Hb6zYRlx8Xsqj1/j1rYGfpQ21ie9xDFEsFwtSvJ+aRutJrvXUTfAorCDbphUZVXcF2z8L+L94TSCKkhsQ8lFOVvArgNHpXXshcRUQuzXMNyV6YGou+8U1RUMZ6A2gIeaOhXLY0neG5sVo74hw5HweMYiACtKhR1SMXWnOceOHtqcEfw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 05 Jul 2022 12:34:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYkGnF2mJV3nmWm0mEL2tvTat45a1vtkuA
- Thread-topic: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation
Hi Xenia,
> On 5 Jul 2022, at 13:21, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
>
> Add the function prototype of show_stack() in <asm/processor.h> header file
> so that it is visible before its definition in traps.c.
>
> Although show_stack() is referenced only in traps.c, it is declared with
> external linkage because, during development, it is often called also by
> other files for debugging purposes. Declaring it static would increase
> development effort. Add appropriate comment
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/include/asm/processor.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/arm/include/asm/processor.h
> b/xen/arch/arm/include/asm/processor.h
> index 4188ec6bfb..c021160412 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[];
> void panic_PAR(uint64_t par);
>
> void show_execution_state(const struct cpu_user_regs *regs);
> +/* Debugging functions are declared with external linkage to aid
> development. */
> void show_registers(const struct cpu_user_regs *regs);
> +void show_stack(const struct cpu_user_regs *regs);
> //#define dump_execution_state()
> run_in_exception_handler(show_execution_state)
> #define dump_execution_state() WARN()
>
> --
> 2.34.1
>
|
