[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 16/25] libs/libs.mk: Remove the need for $(PKG_CONFIG_INST)
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 5 Jul 2022 13:27:13 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvvWkkQIw2EDI2UOoH1zyEnMBj4a0QaZXykYEIApz5g=; b=iYCRmXTWH3R41aopRWjO0W+Kd9b0sG6NkeTiQiriUBgPQemiZ5lk4gUF9y/giUlSIt6J3pVSVu3Vq+GOS7UHEOegMsNCjOJ5SjsXzhm+ilXKvsuWfAhSR/sKCMTrGIRMkHBORPEvdUeXFPiR5cJPKS3Up2SN0zDmNKpsRuCw7Zc2tFZ60Zh45Yji6o58VRXNxnXD5iwh97rraVStNRGEpUZ67gXloV63/odB+xa4s3POBE3JecCEpNnrmOkpdSnBoVYknYGKzvTN8lHgTp1liTNAwzhSXpI+/nljSviMEBoP2P6EJPtWjNRG8R855+EzJXQt4nizb+PzEAO8QpR4GA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvvWkkQIw2EDI2UOoH1zyEnMBj4a0QaZXykYEIApz5g=; b=fDJecEfGK1P4+0dFygaKZ65XCd9XW6rL29O5j5dl4n9y0H2yOVOkwxo7bM81AN5JrMlO0XzggtUiRBIjLrKlNvkrcPgZlUdMrDj+OGCADr0SLELkoHas1AafgKqQUsw1tzEzRQ0rdQl1Pmx9jwgPRBzteov2mvYHYUCH9eOlrA2UfyGYI6PAxrJcQ8hKIjOxZnNHdN2jVyZhXcxbtSQRQPIKkXrWMUzj2VveZcKJCXDIKvTVLiTmACiz57EpU7lJ69bQ+rneKHiBg0vGCMn1aC3tHzcJirrDKVBCx6a8L3pltqDOIGfPU0nwWzHUM+k/XTGg74f6thCmuBtoS4Azfw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XyuxXmiiYbiRSPW4KJfkYswPm1LDUL9Ma9vg+pRvNWUwU+1IS6h1Y4AZGC3hh1t+C/BVNPFqi7RPdfcIlSxE1UZCKWcxaEMBt48zO3IgeFEPSmHvKeol8GJyAe7fR4C1WqQ6ewLlSOdDN6fKibRgFI6do1ri375UIfzslfV7PEQ4KIKbcseA2qZIcPtPbAFm6fidc5BZjnTgSatu7xiuH524wGAq4DqQ9stFfq4agNhBC+5/XyZT1xsCojuC/7pZGu3CRfJFooVHqPfXyK0fAOaTD8F3ilTcVO3aT3QhSJ0NoQdlG1FfAwW/7W2R5Gk3yOMNvPh4SkmZhZuvy8mmDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXHOKbl6T8PaW7dgxCcHQYVNtvBqgTWVZQ7RxlJkywrghAnSw3UBFcPPyNoy0mqwcgGKZZcy19Lj7Ps9a8WDUHrEd1J6uyD/zYP7hSYkKrinKbFDCfwrioTl3qmDXI1svKC5zFUUe5QpxV9zW4AHI+qcIWoiB5RHOo9L7L2UZHDVsy2RF8RgAoMd+TXLejYgRN3aJJPdcSJnanoO/lu4//XArNyPtSReJ960btlGaMcyULCNLBfOKSf9CuR5ZmNbi9Xv3Rhbu0Vh2qGDlLXcRIMJHv3w27eZ+SXOh0FxscIVJAvUOFl4EVjhfs0gEesXNsAhyAqqTnue2B/zFeJXwg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 05 Jul 2022 13:27:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+RFzqfxR1Q720uC1zVKAzFjWq1v1hUA
- Thread-topic: [XEN PATCH v3 16/25] libs/libs.mk: Remove the need for $(PKG_CONFIG_INST)
Hi Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> We can simply use $(PKG_CONFIG) to set the parameters, and add it to
> $(TARGETS) as necessary.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> tools/libs/libs.mk | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
> index e02f91f95e..7aee449370 100644
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -37,10 +37,10 @@ PKG_CONFIG_LIB := $(LIB_FILE_NAME)
> PKG_CONFIG_REQPRIV := $(subst $(space),$(comma),$(strip $(foreach
> lib,$(patsubst ctrl,control,$(USELIBS_$(LIBNAME))),xen$(lib))))
>
> ifneq ($(CONFIG_LIBXC_MINIOS),y)
> -PKG_CONFIG_INST := $(PKG_CONFIG)
> -$(PKG_CONFIG_INST): PKG_CONFIG_PREFIX = $(prefix)
> -$(PKG_CONFIG_INST): PKG_CONFIG_INCDIR = $(includedir)
> -$(PKG_CONFIG_INST): PKG_CONFIG_LIBDIR = $(libdir)
> +TARGETS += $(PKG_CONFIG)
> +$(PKG_CONFIG): PKG_CONFIG_PREFIX = $(prefix)
> +$(PKG_CONFIG): PKG_CONFIG_INCDIR = $(includedir)
> +$(PKG_CONFIG): PKG_CONFIG_LIBDIR = $(libdir)
> endif
>
> PKG_CONFIG_LOCAL := $(PKG_CONFIG_DIR)/$(PKG_CONFIG)
> @@ -55,7 +55,7 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_INCLUDE)
> $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR = $(CURDIR)
>
> .PHONY: all
> -all: headers.chk $(TARGETS) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL)
> libxen$(LIBNAME).map $(LIBHEADERS)
> +all: headers.chk $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map
> $(LIBHEADERS)
>
> ifneq ($(NO_HEADERS_CHK),y)
> headers.chk:
> @@ -127,7 +127,6 @@ clean::
> rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS)
> rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
> lib$(LIB_FILE_NAME).so.$(MAJOR)
> rm -f headers.chk headers.lst
> - rm -f $(PKG_CONFIG)
>
> .PHONY: distclean
> distclean: clean
> --
> Anthony PERARD
>
>
|
