[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 17/25] libs/libs.mk: Rework target headers.chk dependencies
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 5 Jul 2022 13:29:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QZRUVt6T4fRC/hSuLzaHk5FIy9dURYF/Ez4GzpFDPTY=; b=JZmQuPe3Va9o12JN/AeuAzRckX0Si+i7ClhJuyDXVmotuOTpeRmQEEBCXgMnjHoqJ2twMmkwNshRIvjkJW9jUpDWZWg3MPHGQMqZtjwf4IbUcSN+1gm/7xQOHJboIkgvqD8HAxzunLHbfYQECgweJyXB7EFGWo6xXlyj6wv8kb+8vhuV8evTyBlCRBsPuiCVrrTdtDgGgXAuEPT+F/Ns7P+zHDPbPKSKIrhzcfCYyvnhMT9oaMZugYsu/VGoIZ8LfEMxCR9du8GQim+P8WAazHMOchPnbTJ8kgXWzlcANHK3K4OMt+ZeVZ1j2E4TbbBmM/KPN/AWuvekL2AyAt+OOQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QZRUVt6T4fRC/hSuLzaHk5FIy9dURYF/Ez4GzpFDPTY=; b=HKC2JaxF5mN3HSbkMJpMXRTDVG4gswNmt58dtXLtN7A+OjE/X7kyKy54P707/Fu7KRvXYQF/EjKDuuL5AV4k0cWexwQrZXqvA8Iy1bBbEGF1sS9lInr9VQ1OILr0yk38bSOzFC5CJ9LRvQRcgyLJnpffyKrF1bqm5+HiBAaPL1VbRT3tz9ySM4iEuyobbuafidEPK891Qae2A/BLHPUpIpijQyGEr+TepMP9f0Tdim1AJUqJfIeofhdclMm54jQM8tSNSXKjY7E4WSAamB7dIsONSBUi9e12PR1PWBWNFQ6xd74SQLaK977ZGTPckJryKjBG3AXfJk1233DX0kh58Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m88tbrFWFCZwBr3eP263jlwqRkw8s9Q6PWLXhKMNj6zNJjiyZTfHxW6H7qnTZCp/lzhG1mUc+noT34sw6Z/ZtmPAj+pOkiAzcTVPU+P4lfEKnEyW7s2sKAQfS+KNfxik4yBMm5khJ6TIjLdPAir1S/gzInZBYTAlHPP83s5mcF4VHSwSgM+BoFWpQkpfJE8cYoBKaj6CSuSLRNGbqOPbYjpUZpcPLr9IFZ8AzgXTV1oGmmTqbjndliyQvWTuQML8tXSAIlEvhw4abGN5RCyZF5NcL8RfigcLC7cU3wr+/mSaCZRsrZeYowTo7CniAWokalGFKaObgoGfxNK7eFTk6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlngEC1QADEXjnNopGdN6Ywj7cLcnA46tc4ERYwJf00/auUEG9doUhEKUnxBganSnUyfut40CZzZ9DEYFgjmXDYzcM8lwsj46iQyMP4cXIYW2JzQEUNXjbfDDzkQB2c20n/Iy7HKIr4Yxze/ovjuDn/+9Af1oqYppx3Haze/BjkYf3sDUehOrhSHdbcr+5JQPpaEUDGbHatJbv6CQjmiv/ddYqSL89DLPblhbYInm7vgKmwHEqbMSzEpYTIUwCsjnpGlXDCixnMHVGc/X/+YJECcNG6gCHjC3aPevmUkT2cHp+bO0DSFPU+V/OWNtQVLo0tfZPm3D8rYo0ns9iQvkA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 05 Jul 2022 13:29:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+Q1zaZSd9AMO0OKzG6eXIwYj61v1qOA
- Thread-topic: [XEN PATCH v3 17/25] libs/libs.mk: Rework target headers.chk dependencies
Hi Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> There is no need to call the "headers.chk" target when it isn't
> wanted, so it never need to be .PHONY.
>
> Also, there is no more reason to separate the prerequisites from the
> recipe.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> tools/libs/libs.mk | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
> index 7aee449370..f778a7df82 100644
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -55,22 +55,20 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_INCLUDE)
> $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR = $(CURDIR)
>
> .PHONY: all
> -all: headers.chk $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map
> $(LIBHEADERS)
> +all: $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map $(LIBHEADERS)
>
> ifneq ($(NO_HEADERS_CHK),y)
> -headers.chk:
> +all: headers.chk
> +
> +headers.chk: $(LIBHEADERS) $(AUTOINCS)
> for i in $(filter %.h,$^); do \
> $(CC) -x c -ansi -Wall -Werror $(CFLAGS_xeninclude) \
> -S -o /dev/null $$i || exit 1; \
> echo $$i; \
> done >$@.new
> mv $@.new $@
> -else
> -.PHONY: headers.chk
> endif
>
> -headers.chk: $(LIBHEADERS) $(AUTOINCS)
> -
> headers.lst: FORCE
> @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp
> @$(call move-if-changed,$@.tmp,$@)
> --
> Anthony PERARD
>
>
|
