[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] xen/evtchn: don't close the static event channel.
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 5 Jul 2022 17:26:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N9Fum4iO+jl06LBYo1mVpIcFvFCt32NSuWlXNSILZq8=; b=GE8NIm3LXyi6Y8vKFx3cicRiMWcL9R2wkFvMqadBbGEaE8W/Pc0KYoojep4/8JkV2eZcnAyojiO2L8/R+2A3MSNmJYsKT4BiD5qTva+RpdKjoRAJeeUZ5eco8lv0hifNr5qmtiG5zf4XPEcd/uoG/A6tUci+A+3NHZ/qgYmZYjNNSkjlEvoWm2klZfH9Ow8YXkOzVLBckbN9G3QX2MFwodyno3tocAs7f6cUiG/Wps9S31iN+/sQue96coiFBGJlAJHSgJXOVp48gC26dik0wgjArROnyRVIavDJAaZv0mkdfS3XUC1hDDA+v1R5t6T6haido2H2kyF5W5fSKAGlFQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XJ28TGfPqxth5vtV3hw2byKK9ukTOcyQUj1wysb4JF67fVFK92ZrkAFKKOUAkcsudoqxeEXU5YBrzVejFy75hKmnzu+hwLST9WCRvTNx4J1oUdazyNPdXeuAb4/FpG6tIGdbc+heE2HafhZw0HorQRAvwY+oHMtqZVVl5cZR3hXeoFrZtgIaCJArwTk+Oy9T47os1Hq9oFw/1lREwPyYPppERskI46SLbKqlHXPEwKytcWm/h+zV6M9PX4AWIGeAtrAb3NPHzsA8IHLM2v5YDbNkOa9lY+iXb6nmiCzbQzuwWxxIe4L2ibo5oCr7YQQunCL/RzqUxsCQSL+4WSuT5g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 05 Jul 2022 15:26:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2022 16:38, Rahul Singh wrote:
> --- a/xen/include/xen/event.h
> +++ b/xen/include/xen/event.h
> @@ -73,12 +73,12 @@ int evtchn_allocate_port(struct domain *d, unsigned int
> port);
>
> /* Allocate a new event channel */
> int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc,
> - evtchn_port_t port);
> + evtchn_port_t port, bool is_static);
>
> /* Bind an event channel port to interdomain */
> int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind,
> struct domain *ld,
> - evtchn_port_t port);
> + evtchn_port_t port, bool is_static);
Didn't even pay attention to this the first time through: You're
again touching functions you did alter already in earlier patches,
and with them their pre-existing call sites. This is not only
unnecessary code churn but also makes it harder to follow where a
change came from when (perhaps much later) using "git blame" or
alike. Please bring these functions into their intended shape in
a single step (each).
Jan
|
