Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

[Xenia Ragiadakou <burzalodowa@xxxxxxxxx>]

Hi Jan,

On 7/6/22 10:10, Jan Beulich wrote:
> On 05.07.2022 23:02, Xenia Ragiadakou wrote:
> > The function idle_loop() is referenced only in domain.c.
> > Change its linkage from external to internal by adding the storage-class
> > specifier static to its definitions.
> >
> > Since idle_loop() is referenced only in inline assembly, add the 'used'
> > attribute to suppress unused-function compiler warning.
> While I see that Julien has already acked the patch, I'd like to point
> out that using __used here is somewhat bogus. Imo the better approach
> is to properly make visible to the compiler that the symbol is used by
> the asm(), by adding a fake(?) input.
I 'm afraid I do not understand what do you mean by "adding a fake(?) 
input". Can you please elaborate a little on your suggestion?
--
Xenia