[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Jul 2022 17:38:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f3IdF4c0WU+gLVVFCtReB28pUQ+BMTUs0ANzgGR34Js=; b=nyAbAY514Wym3ZTCLBmno4QOoTUnGZAOtjLCTcGwZPlYRpjxZcH7C0jI8IaNzrwNaiKK1GOOShaw4U4aa+gRVzIpii3mWm7NWu5S7XuuOsEey/4PrVJl4XGny9tqSK2rvZS+gIr63BDPosHHXbxIGXU/DhBkZZQXCiz97XhqJkVKQlCVw6JbZ5WjIM3f+dC3ongTXErTxgkmxXUrxE2AJ2hlziMqVROM1ZSbu6U3jrjTn31gLp0eRwuSnutVbP9Dk/lcyzWDDByyJq3V1R2VKm/Gl8YftpNAyVcoGRoitia87C1oN2w9lEvkTVvJ/eoHd5RSC8ScdLLOryeqgwCjcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7kdJ+a5X3NrMmJggnq6MHOGGmLrkuQg2jpxNN4y4kS//NoqoqSm1YyURKLxYUqVSE83Hk7pIT2Dhzhib/+yxift/bhPZ/u9Ybw9Qe9Stx7XTrTOF0TeCxjPCdHEh6z2rH2xrTNo3AyybdBxzK/uckLCBAyvi1+L3hKx+9f41enbSnAwiHx6FaguGNWTaoSmrkSoeMzqFqlyhjo5MEATUa5N68pI1dlUGgjEmQAQYn4bCdf/iVATc47klS1UulkPdWW6Gj/PKfiEswx4Gfu3nZ4FakQqmbGq7/EBs09zj6K1qIkn7lwG83nZ+H8BoUR5hZR45yjgcANv7dhCt1UQvg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 06 Jul 2022 15:38:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2022 17:17, Anthony PERARD wrote:
> On Thu, Jun 09, 2022 at 05:52:45PM +0200, Jan Beulich wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -465,6 +465,22 @@ endif
>> .PHONY: _build
>> _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
>>
>> +# Strip
>> +#
>> +# INSTALL_EFI_STRIP, if defined, will cause xen.efi to be stripped before it
>> +# is installed. If INSTALL_EFI_STRIP is '1', then the default option
>> +# --strip-debug will be used. Otherwise, INSTALL_EFI_STRIP value will be
>> used
>> +# as the option(s) to the strip command.
>
> It would be useful to also document INSTALL_EFI_STRIP in ./INSTALL or in
> ./docs/misc/efi.pandoc (efi.pandoc is where EFI_VENDOR is documented for
> example, so probably a better place for the doc of the new option).
Well, imo it's far preferable to install _something_ that works (even
if it consumes more space) than not installing anything.
I'll look into addressing the other two comments you gave.
Jan
|
