Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu

[Xenia Ragiadakou <burzalodowa@xxxxxxxxx>]

On 7/8/22 10:35, Julien Grall wrote:
> Hi,
>
> On 08/07/2022 00:05, Stefano Stabellini wrote:
> > On Thu, 7 Jul 2022, Julien Grall wrote:
> > > > +# Run the test
> > > > +rm -f qemu-staticmem.serial
> > > > +set +e
> > > > +echo "  virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 
> > > > 0x40000000"| \
> > > > +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \
> > > > +    -M virtualization=true \
> > > > +    -M virt \
> > > > +    -M virt,gic-version=2 \
> > > > +    -cpu cortex-a57 \
> > > > +    -smp 2 \
> > > > +    -m 8G \
> > > > +    -no-reboot \
> > > > +    -device virtio-net-pci,netdev=vnet0 -netdev 
> > > > user,id=vnet0,tftp=binaries
> > > > \
> > > > +    -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \
> > > > +    -dtb ./binaries/virt-gicv2.dtb \
> > > > +    |& tee qemu-staticmem.serial
> > > > +
> > > > +set -e
> > > A lot of the code above is duplicated from qemu-smoke-arm64.sh. I 
> > > think it
> > > would be better to consolidate in a single script. Looking briefly 
> > > throught
> > > the existing scripts, it looks like it is possible to pass arguments 
> > > (see
> > > qemu-smoke-x86-64.sh).
> > One idea would be to make the script common and "source" a second
> > script or config file with just the ImageBuilder configuration because
> > it looks like it is the only thing different.
> This would mean creating a new bash script for every new test. This 
> sounds a bit pointless if the only difference is the ImageBuilder 
> configuration. Instead, it would be better to pass an argument to the 
> script (like qemu-smoke-x86-64.sh) indicating which test we are going to 
> perform.
I agree with Julien, also because the ImageBuilder script depends on how 
qemu is configured. It is not completely independent.
--
Xenia