Re: [PATCH 2/3] xen/cmdline: Extend parse_boolean() to signal a name match

[Juergen Gross <jgross@xxxxxxxx>]

On 08.07.22 18:19, Andrew Cooper wrote:
> This will help parsing a sub-option which has boolean and non-boolean options
> available.
>
> First, rework 'int val' into 'bool has_neg_prefix'.  This inverts it's value,
> but the resulting logic is far easier to follow.
>
> Second, reject anything of the form 'no-$FOO=' which excludes ambiguous
> constructs such as 'no-$foo=yes' which have never been valid.
>
> This just leaves the case where everything is otherwise fine, but parse_bool()
> can't interpret the provided string.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature