[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9] Preserve the EFI System Resource Table for dom0
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 11 Jul 2022 10:32:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jjrHqJ+4T+EXjrFd2As2FR11kJL8/AyAArI5WMMQFU=; b=agCbFXL7QCDQbdtmeRX8ard8B45M7CtTczjLub6+m7dN424m5X0fN4pFMqNtn/tLD0PSESMTFLP+eWc/bduhymNmb0BZ1FSAs0BaFd7FUBJameENbdrB77E3co28OgVMqQLabTIJlcCtxUmnqHWA+/4A6S9HlCyTj69cHz+MXOvYrb4NFyCq/g7yx+KluPVCZXjrz1wX7La4sd/acMY1RMhqT9L2VFAB1aawtQh3E0PIyqmgUJAm5bOIK+YQGEa4zAjusLgYGiNyLE/y5GryV2WrJwZvG0qOueZuwGCc8oauI8gFc47lHVevPOVjQf5EoBycQ8jgzpx8mSOKVHyLeA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjVLt7oYf+ZWIXVWWoP9DfNH3BWvuUat2moYyaQkuAphqktiCGyYNyS/vAFUiJ8Fis5cZ90F7IBFMAKa51VJ6sleF5E62oXqDgy3NY443SRRFG0KJohEd3+sC8sGwxvvLzk1XF4/wgPZ3tRjhekAt54xmLmg26vEYN826MqOyyCWb5HwXWnD2jCdqQmQ7odktP/kN1BMPFqHXr7ultgq05z3Uc+vcgjFB1a/r9jrcGxd8bSrwyCU5nsspRyUrrQsdO+exQbPZT+j8tgMx4pjSI2d4coTicRFCLTyQItrZ5cdxxs324PkiOSkAfkqK3bjUmRfHL1+fAAVM5xDoBRedQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 11 Jul 2022 08:32:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.07.2022 10:30, Demi Marie Obenour wrote:
> On Mon, Jul 11, 2022 at 08:41:59AM +0200, Jan Beulich wrote:
>> On 08.07.2022 23:34, Demi Marie Obenour wrote:
>>> @@ -1051,6 +1110,70 @@ static void __init
>>> efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop
>>> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \
>>> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32))
>>>
>>> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable)
>>> +{
>>> + EFI_STATUS status;
>>> + UINTN info_size = 0, map_key, mdesc_size;
>>> + void *memory_map = NULL;
>>> + UINT32 ver;
>>> + unsigned int i;
>>> +
>>> + for ( ; ; ) {
>>
>> I'm sorry, but I'm now going to be picky and _not_ offer correcting
>> this style violation for you anymore.
>
> No apology needed. Is the problem that the brace should be on a
> separate line, that the spaces around the semicolons should be removed,
> or both?
The former. Iirc you did actually _add_ the spaces upon my request.
Jan
|
