[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 11 Jul 2022 13:40:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kiDl7AjcjKfAQDcF4b1pL5X+NtcCzrj+va2tVc3T7nU=; b=cU4NaVXZRGCkJvYCSnsypyhV7tn1K+yECBPq4O4+prHCSASLtfAHkce3Ut5+jPPxda5kfo2QlWIApHd/ey29O4LBkH4d3e/BM+RSxm13RvJ96eS1xqYuzPLPx9r4TwgdjU1iThK0i4sSoRwDdwMvtHk7jSzQOiSrMaIA9wEe06twjSIejkVne7WA/Lp6aOdqLg7kOJoJUVIb2xnlOx9ueoYT2fA0ocADK7BJzDI4RSmNF/RhbEnLARNGB/Nvsta42U6xQAdvvL5nHsiY9eXG3ZXyjcsBq8ydImvYPuVpu1yWKS/KT56aKb0EKo7/UmuEWOmZguVaYV7ymNF6uEc27w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kiDl7AjcjKfAQDcF4b1pL5X+NtcCzrj+va2tVc3T7nU=; b=PzNWAMqh/+xBlsBhyYl9JvGIyMC/s0prXxbhh8MkocmBKHzh7qfWRCpZsQecA00fLGdI90hqHOO7avOSPHb+KIc8bHLwnw0Uz9y3xgbdZz8K2Zeux7LAG/XPPFDUt8ZNREGe3fCHrICMRr+iNHQIEqXtMkF/5DQykIWR5dcOAo5motyzgyeSorAVfOsVGbSrgHAbGDoOvu+I5biTH5yVRAXFaNDoSAOudBZRS8s3t/oFpAaRwi9hA8nlEWGVydKDeHyjxw6ylqdi6ePPcQaLxAzXfisnQQKmH40Sn+icxbSpa467vzRyUJaSn0o7iRb2bGzn3G1b4gvX9clCFRx7BA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nzX0EM9ELMGczQnvtOdm3ynPBktFYg92hmiirsklHr+CAtW8vpUMgItQX7l/syRV9AV0biJwMjgzX3CdgfGe7uys27dTG7l+e6fdA/GTp+wrsPrIYD/sTbSakOrFNrrtTjQ3TFcp/gtVnleTUc7BwCbwd+nsXIWNs++7bI6QPJWSvYhtSHUSJoc+Ge+6TxpM60Sd+/hgMaRzJudsdJWkegqanBAAJm15W9nJjomRsAmQSNjKPBObmBCr2JpHd/WgL8GyoPmAMHpy2PRogplVelI4ZaWSy8Q6giCcqBGGPybL9JElikICN6ur9fyKK8woW0aNL5w/XMM1KxW+WCJUcQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K21GRh6bKPRf/KnUkF6hYJ+QKClSM/lVcKwCnDKJl+mO072n6e7v9DLrUeg669KqRKWQJeagbSTXDdGxyZW2d75HwOOw6KY7fKeqt5gKPJUGTSC1NMdHHFApmCd4OgTySn5NVwPySnqdqXCU8b8EMubCdAfNtTlA6KuaDfLoW1o6D8Mrd1pALTkUdeDJ5iu6plnXEbHq30MtLCiOWCKRzHwERaA/TBGs8/WDRd+WIB9Yj2zoivwTSmVhJtnsh/8fRjpr5eiuEJnZSae+WYMiYYugSJdHH5agF2ibboKc6P2FIbmI3YffDLtpTaxL+/0AaKc8SNB8VjOKf7gapgXTTA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 11 Jul 2022 13:40:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+Qt/49JLdoEv0uAADgNQkPLF610seaAgASVSoCAAACRgA==
- Thread-topic: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile
> On 11 Jul 2022, at 14:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> On Fri, Jul 08, 2022 at 03:39:00PM +0000, Luca Fancellu wrote:
>>> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
> [...]
>>> For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
>>> full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
>>> to "mv", in case the target already exist.
>>>
>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>> ---
>>> diff --git a/tools/firmware/hvmloader/Makefile
>>> b/tools/firmware/hvmloader/Makefile
>>> index b754220839..fc20932110 100644
>>> --- a/tools/firmware/hvmloader/Makefile
>>> +++ b/tools/firmware/hvmloader/Makefile
>>> @@ -87,21 +89,21 @@ roms.inc: $(ROMS)
>>>
>>> ifneq ($(ROMBIOS_ROM),)
>>> echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new
>>> - sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
>>> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
>>> echo "#endif" >> $@.new
>>> endif
>>>
>>> ifneq ($(STDVGA_ROM),)
>>> echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
>>> - sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new
>>> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >>
>>> $@.new
>>> echo "#endif" >> $@.new
>>> endif
>>> ifneq ($(CIRRUSVGA_ROM),)
>>> echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
>>> - sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
>>> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga
>>> $(CIRRUSVGA_ROM) >> $@.new
>>> echo "#endif" >> $@.new
>>> endif
>>> - mv $@.new $@
>>> + mv -f $@.new $@
>>
>> Here, instead of -f, is it safer -u? What’s your opinion on that? The patch
>> looks good to me.
>
> make want to rebuild the target, so there is no reason to keep the
> existing target. We do need to overwrite the existing target if it
> exist.
>
> Thanks for the reviews!
Ok thanks for the clarification, as I said the changes looks good to me:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> --
> Anthony PERARD
|
