[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 11 Jul 2022 18:01:48 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 11 Jul 2022 17:02:20 +0000
- Ironport-data: A9a23:5+LtTKtQWtwMIeeMa2Yi42NJ5OfnVAZeMUV32f8akzHdYApBsoF/q tZmKT2AbvuNMDPyKYpyO4Xg/BwBv5HXytRkSgJt+SEwRnka+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zU4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8ZBJfTgMlGViBqEiN3MoxU24TheWOg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWUzPEicOkIVUrsRIM07wPvzvSPQShxdpXW2jLgK31mU7RMkhdABN/KKI4fXFK25hH2wt m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZ1hHWDy2pVDwcZPXO5q/Skjk+1W/pEN lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l+pDu/B60XW09fD9DYdMHpuwNY2Qxy Qrc9z/2PgCDoIF5WFrEqOrL9mvoZHFMRYMRTXRaFFVYurEPtKl210uSFYg7TcZZm/WvQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhKTysDA3Fd4acO6koqCp5 RDoYfS24uEUFo2qnyeQWugLF7zBz6/bbWKA3g42QMVwrWjFF5ufkWd4uWsWGauUGpxcJW+Bj LH742u9G6O/zFP1NPQqMupd+uwhzLT6FMSNa804muFmO8ArHCfepXkGTRfJgwjFzRl3+Ylia MjzTCpZJStDYUiR5GHuF7l1PH5C7n1W+F4/sriikk73gOrANC7IIVrHWXPXBt0EAGq/iF292 75i2wGikH2zjMWWjvHrzLMu
- Ironport-hdrordr: A9a23:UH5KR627HTHLbmNtk+RMggqjBLIkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAs5D4bbLbGSS4/yU3DWF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jul 11, 2022 at 03:52:52PM +0200, Jan Beulich wrote:
> On 24.06.2022 18:04, Anthony PERARD wrote:
> > Setup proper dependencies with libacpi so we don't need to run "make
> > hvmloader" in the "all" target. ("build.o" new prerequisite isn't
> > exactly proper but a side effect of building the $(DSDT_FILES) is to
> > generate the "ssdt_*.h" needed by "build.o".)
>
> Maybe leave a brief comment there?
Sounds good.
> > Make use if "-iquote" instead of a plain "-I".
> >
> > For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
> > full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
> > to "mv", in case the target already exist.
>
> Hmm - according to my understanding -f isn't needed just because the
> file may already exist. It would be needed if a pre-existing file
> isn't writable. (I don't mind the addition of the flag, but I think
> what you say can end up misleading.)
Yes. After reading the posix doc about `mv`, the following would be
better:
Lastly, add "-f" flag to "mv" to avoid a prompt in case the target
already exist and we don't have write permission.
Thanks,
--
Anthony PERARD
|
