[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 12 Jul 2022 16:34:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1UQmCyms89YdEei4/5r4TKQHX9dwAudCy+K65B1AbcM=; b=EqGoLlKbItvTf+1sIBOPMBXwkO4SkMvVsJFgRanHK+bE3A/aHEISi0En8nUq64prB7XyE2nULJi1daftZ+4Kd1jYIdIVV5jOFzfkVd3QW98wWSCPBw6FRBE0385mxXF8aB/yQ8NOp8iqpDSt70y1l4HwSLHh1RPT+a1vracVb10LOBTlNVvGrvliUKwSrgelptBuqd3MawbDQWHlgMzxUukrQZ1nbgY3L41Gl2A8EKbSNitOPn7NnFaAczmiidbf3RHl/1U5kGO2JBVOJ5ctTkcyzJcaUh5oaF0rdHi33d5XXYeT20g6eO+HyuTpHFZLc6Ybt+kgDib+q8q1YkuzbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lHvRRJ6reAYX61sG4F8u8llbd1VSS4/uljXaaiaXxtoeu9FOJxHRy2jfodwebqraH1Z/bWiOz8PwREOZ+7CikCoDaG3z69HeluWXJNQUH/4UFrOvvj4iCEY58mQu+zbdZqm3q+aKI7W5paXei/AuaEBqZ7pDmlqO9OfG2TGaC7nStch51TPtZAp586q/HlCuFsPJXM7fCHkRozrZ/ju9I9v1zp86m9jpEqxhSo84ctVdzcANN6RgH+Os1NklzSqvtx2GYf2jg5ggjR5DBfNLsCEm6pLk1iy2AfLwWDvRUPSoDRra0oSfmCoXp/VFSfpTnF9JMQnPp+jo9yYwzmHqRQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 12 Jul 2022 14:34:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.07.2022 16:54, Wei Chen wrote:
> --- a/xen/arch/Kconfig
> +++ b/xen/arch/Kconfig
> @@ -17,3 +17,14 @@ config NR_CPUS
> For CPU cores which support Simultaneous Multi-Threading or similar
> technologies, this the number of logical threads which Xen will
> support.
> +
> +config NR_NUMA_NODES
> + int "Maximum number of NUMA nodes supported"
> + range 1 255
> + default "64"
> + depends on NUMA
Does 1 make sense? That's not going to be NUMA then, I would say.
Does the value being (perhaps far) larger than NR_CPUS make sense?
Why does the range end at a not-power-of-2 value? (I was actually
going to suggest to have a shift value specified here, until
spotting that NODES_SHIFT isn't used anywhere else, and hence
you're rightfully deleting it.)
> + help
> + Controls the build-time size of various arrays and bitmaps
> + associated with multiple-nodes management. It is the upper bound of
> + the number of NUMA nodes that the scheduler, memory allocation and
> + other NUMA-aware components can handle.
Nit: indentation.
Jan
|
