[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH net-next 1/2] xen-netfront: remove leftover call to xennet_tx_buf_gc()
- To: "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Jul 2022 11:19:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vhtVsjJvr1mt+FAEVzCyU+1pVcikUQd+0/H1IYoovTs=; b=k/XlSXaAqLCzqbucaxGuFhT/UJ0iZAWI5OgrppXj6cXkw5lGi0ieL5KwBo8cfzc7D/lexkTrEUeMFmPI74ACQAXPUGOqLfCu27Tku0qCrxDWNJ79UIeQKkAmxFH1q+tCbyDltZ8ZgESl5mOcV8wT0nbxHyM/Pv1GV0LKrLrTVbY5ULFBeiM7NeyBrSF1HDTyBVJ8JkuyinC8985PkPMr8K56F0+uoLxchEPKs0pb3DbLl+AiTYotP0RlE0R5OH31EJ8CmkqYCgEGgRwgWaigROrGpvIjLWU89Ek+efHmoV7nsO2BbJKxZ5FQmp9EPDYo0rmhTOBX5ArEwkxvHTKtWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z7l51EExKX7zn7yX5mO38bvbT33H6yeap9CwD8cFuFXk4F+R0PoZWruLXjsiUXsJDxrfkYBb3AM4jPkYMmRWx83BWgEMoh2ftiZZLmpU+mGAO/w9+rouVQlQAjLg+k/qNHJulES9/5w+gKsZrjosMgxW0QqeKVhF2apQKvkvfypthObEWurqPCQPsh7tSu06X0d4w4jms1Y0o7yhkX6QOxXNx7oMqJGdzT1fg9ihBnYo7/4ja7T5UgXkO3nPmAdRxlzS20D9iepapxq/dw3Ib4mZQls9erkmvAjHPDT1XuNdVurp/LvBKZQ+tf4nfnGj0t6VzoZJXv55V4F/b5wKVw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <stefano@xxxxxxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- Delivery-date: Wed, 13 Jul 2022 09:19:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
In talk_to_netback(), called earlier from xennet_connect(), queues and
shared rings were just re-initialized, so all this function call could
result in is setting ->broken (again) right away in case any unconsumed
responses were found.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2464,10 +2464,6 @@ static int xennet_connect(struct net_dev
if (queue->tx_irq != queue->rx_irq)
notify_remote_via_irq(queue->rx_irq);
- spin_lock_irq(&queue->tx_lock);
- xennet_tx_buf_gc(queue);
- spin_unlock_irq(&queue->tx_lock);
-
spin_lock_bh(&queue->rx_lock);
xennet_alloc_rx_buffers(queue);
spin_unlock_bh(&queue->rx_lock);
|
