[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/9] xen/x86: use arch_get_memory_map to get information from E820 map
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Jul 2022 15:43:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=apLZ7A4dBGVtT0G2VX81kmlDBasKgsOC2GGKrwnukqQ=; b=OkkZh5Nad95xqb0A+HOZgvLbXJtjplnxYe61C1eHxvALLZxUxWtShou6pnqghyz/8fwQjmkdtadWD84q3OTO8Gvx3wBR9PXBOhJOGqu2FXdljg3tKyRiqQkPBbkEFcgEmjl6stZVQwt3v/mRivSUnRjtk/FUwoHW7IjI+iPBtbAUFLRidFQTT4vn6KmFIiP9WFXPZREW6OUOV64Z3mtLBEJ/DCDMffcFOdDIREp885/vdj4z0EpDno5i3J/OJ67Xd3mV4rIB4KrofHAtabGpm2/WOUd68+bbRm5otQqOTdIw741QTSqLfURFlPWPyWT72++HTALOPGAx7e7k61Du6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HvNwdMZu+hEHKWDwCY+of8IJtECOoUf7e+kOL9mYwjn63PoY1n1csqC/FiX1kbOJiPnfFHE/W/kqKFsTYNSKm3NEsI3RJgHVXgSSMMK0Pa2y4NHzcCb7PKjdYyXfVpT+vPJq7NBX0RYajn5FAka2ed1yNDZ/8Iv0WMIC9IMIDLU9c2i2DYDYvcdjV3EqGvYwMTYn+X0d8vVVGi+GXciStFLm4qo0tyX0yFgO6K70VQASk6YrF1fSyUGNJkQzBgL81TajY2srqBzoSGM/Ktc7KLt8HWlBgvQVUC/eZNuK+bEvjzaJhR1xeCuRXKXx7FAY+vLnMfAjkoL//3w7M/PGww==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 13 Jul 2022 13:44:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.07.2022 12:37, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年7月12日 21:40
>>
>> On 08.07.2022 16:54, Wei Chen wrote:
>>> @@ -82,3 +83,25 @@ unsigned int __init arch_get_dma_bitsize(void)
>>> flsl(node_start_pfn(node) + node_spanned_pages(node) /
>> 4 - 1)
>>> + PAGE_SHIFT, 32);
>>> }
>>> +
>>> +/*
>>> + * This function provides the ability for caller to get one RAM entry
>>> + * from architectural memory map by index.
>>> + *
>>> + * This function will return zero if it can return a proper RAM entry.
>>> + * otherwise it will return -ENODEV for out of scope index, or return
>>> + * -EINVAL for non-RAM type memory entry.
>>> + */
>>
>> I think the comment also wants to spell out that the range is
>> exclusive at the end (assuming that's suitable for Arm; else now
>> would perhaps be the time to change it).
>>
>
> Did you mean we have to mention the range is [star, end)?
> If yes, I will add related comment.
Yes (worded one way or another).
Jan
|
