[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/5] xen/wait: Improvements


  • To: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 18 Jul 2022 13:11:45 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43kb2Wrds5TSNOBRPSTFd3YDku/KYxEUrcx6EseKCGU=; b=DOC9C/5t0Q7ghmmFyXRFgaCEoJrVyVFMx08Oj8E28mtuwJOzbg8oQMnOaatAAPV4IO+pp5n/4HBoyNg5JCBqqCLm/tEvPw4R1IibsSiX7T6kfhyKuyxbNcjkOXrQ5d/XIRBsYy0NX8nVvFmA7j0qRbrv38+/0POuQgrJS60H7Lhx56zw8u8wZq4IGqKMwXULjH+sps/I4TS23mP0y1aOQSjBVGPtJUWgkQOMXSkVKpkFv7XsHXx3GbscCcyjqJ/JqmHvqTE9L8sQj9Ji0T3nEY1ry0keS5Zi0deQNAdk+js/rfmohFjrWKUbdp0uuaFHZBmCCJ+ilPv5HVRvPiDrsQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g7EYNF0j+kg3WFo8WrkGD+n7F2diC2prlFeYd0dWR2NpHBvlPyWXcXRBFqnpO43kBuZ43BSkkmFsgg6GJujeZxWiMwzDrDx+QsRLUVFZubB2/v2/tOJOItGmex622BOyfTJ4fuoE1j29tdN3MvW1jg4Pe6OxbLVtVluI692z+OfwyDFejAbsO7Q9JyyUMUQMoDrTlenUHlPxUbQLgLUeIDjEnOhL7/zkVk4yBYsFDAaln5UKHgsKQ+gFop6YjkV3XJkShS8lnx9T3z1bA1DeBiWk6PRL9D4zHPoXPco1v26+Ax2XoS5JGJTOl2nN8cPqJtC8kbY576enJ/rSi+C9mw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Mon, 18 Jul 2022 11:11:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.07.2022 09:18, Andrew Cooper wrote:
> This started out as patch 2 for a different task, and quickly identified some
> technical debt, long overdue for cleaning up.
> 
> Andrew Cooper (5):
>   xen/wait: Drop vestigial remnants of TRAP_regs_partial
>   xen/wait: Extend the description of how this logic actually works
>   xen/wait: Minor asm improvements
>   xen/wait: Use relative stack adjustments
>   xen/wait: Remove VCPU_AFFINITY_WAIT

While going through this series I came to notice that we build wait.c even
on Arm, and I couldn't convince myself that wait_event() is actually not
reachable there when e.g. there's an Arm-specific vm_event.c. I would
generally prefer if non-functioning code paths were actually compiled out.

Thoughts?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.