[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1 04/18] x86: refactor entrypoints to new boot info
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Smith, Jackson" <rsmith@xxxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 18 Jul 2022 13:58:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bfgsxtHOgQRRggHd/sEp2IwzSm7ATQj+oNLqHdWz+lM=; b=o6YfVnAAFYMPlGW0Q977gEAF+QiyItBC0Nw6yFiE3wC+5+oWevM3nCs5aL2n7RtQu3nOBtcGYnvIZelA3BuYSKlBydgFqe/UPlG1t/9M+2sqZLIGPCMWiyY8gZqhZStqu2rK+6SnsTx9i5TY6KsMd+3qea53W6YcbCX5fe2hck6cSvvWDouv2t+/XZ4uggJmRU3TNbp3ztQSY/vp6TuXWPjSDDklltub+IvpyrAQpuT4XyYJc/CYZEdyx1IDiIQgBfdY9dspvdLsNEeY8D/hVL/xkgmsGY5VEKvJRAFCC4DhENwx/ciBUEAyYgN9Fa3bntogs51gG1sSo5jIZJotAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=GAEWm03wPPeJV/jtFy2zQEwYP5hcpBdmhHC7h265Dq2/f2wHyRDuvEPPyhJKi0hKxZedkyr3X3eG3w7cBAnEeEu4pXAiMIEmrMbJEJ3ByU00sBPNze9hma3cJ6VVL5aAKgxD06ZjGUbDUQO2/Oo1Jm+Dfpawml9cFOvPyuvVMvFZjYs9DQ8nEPuHWT9chK47+UJJq+gH4ueylUM/n+EFd8EWg+PS8aMPz44MxKTqlf1u6hmqSv7O7rmqVKLrn5G+EDOuvXaTV2LqfJJTNJSVZp9fo4Gq0HlavEv3K9WRk4DX0qzPx2bSyJZJpKnhrOww6e7c8cHEB9vJX5uczu9kOA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org;
- Cc: "scott.davis@xxxxxxxxxx" <scott.davis@xxxxxxxxxx>, "christopher.clark@xxxxxxxxxx" <christopher.clark@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 13:58:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHDrne88XyYXkgxTAt6TFUls0rRYAHkVRHErZp+x6A=
- Thread-topic: [PATCH v1 04/18] x86: refactor entrypoints to new boot info
Hi Daniel,
I hope outlook gets this reply right.
> -----Original Message-----
> Subject: [PATCH v1 04/18] x86: refactor entrypoints to new boot info
> diff --git a/xen/arch/x86/guest/xen/pvh-boot.c
> b/xen/arch/x86/guest/xen/pvh-boot.c
> index 834b1ad16b..28cf5df0a3 100644
> --- a/xen/arch/x86/guest/xen/pvh-boot.c
> +++ b/xen/arch/x86/guest/xen/pvh-boot.c
> @@ -99,13 +118,16 @@ static void __init get_memory_map(void)
> sanitize_e820_map(e820_raw.map, &e820_raw.nr_map);
> }
>
> -void __init pvh_init(multiboot_info_t **mbi, module_t **mod)
> +void __init pvh_init(struct boot_info **bi)
> {
> - convert_pvh_info(mbi, mod);
> + *bi = init_pvh_info();
> + convert_pvh_info(*bi);
>
> hypervisor_probe();
> ASSERT(xen_guest);
>
> + (*bi)->arch->xen_guest = xen_guest;
I think you may have a typo/missed refactoring here?
I changed this line to "(*bi)->arch->xenguest = xen_guest;" to get the
patchset to build.
The arch_boot_info struct in boot_info32.h has a field 'xen_guest' but the
same field in asm/bootinfo.h was re-named from 'xen_guest' to 'xenguest' in
the 'x86: adopt new boot info structures' commit.
What was your intent?
> +
> get_memory_map();
> }
>
Thanks,
Jackson Smith
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
|
