[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation
- To: Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 19 Jul 2022 01:28:47 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z5tcjebPwgcJX/ifsKTVqAV3Ng3khA/KYOBCcGg8hXA=; b=aArtn2jVJUDQ9SuTUnASFYlNf7Wq4XkKXsR0FGe12pBB4Yl1Py6guNcapbpY328/z2iDoFFk1+UgpkvH8Bj5JyWimUoGqSNbTDKbe5fy/4KVal0LmnzeZ+FqdZ5rXsyL8eX/T128CAeB3Iow0Glk3LkgDHgFD9epgkbds/yV9wLvSnBYnVMvr2NoCBNE9UG2O3tQaACbO6NIUJJDMwDS4uHfG4d+R6eQ0sgBwX5CgCNwD/EwMyP1j7N52fn4AqfnmHfQYE88asVGkK/YuMBiWQ7h1AnBvn6+sCvmY8p0HUS6NYcvkAfvRu4EdB4UkL34b+rEfVCFDMvsFvujoCesUw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z5tcjebPwgcJX/ifsKTVqAV3Ng3khA/KYOBCcGg8hXA=; b=nwJwhx8P/u3IYv/jHvfLVzPh1zSZdXpglEVaYXaMBT43kk+oF7HOh02V7S1OqiLRHgZSxJW1biXyXnfLBvJawlP+KV7RMYhxsy+RJhYy/4ZmmW7ZybjNkS5uNCaW4Qxv+WCY+TQCSIsAMk60P8fH16jFiBpU+a8H3tSi5sAz5KALFVUR/xKnh1eJcDZaMYdWzACB1RwERoOfYQrkgU3HV7wS6xBhKdTFirpWcmuIp8RFjznh04eBR6bgsE8yxLShnWsAqMGyk2YjotKYxMtpD8eIHumHGL1v3w4e+rObOGaHzmkXwwUIuMvorCfkn8gyxp49NrE2y4lg+ipD/rGzNA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hDaR7wb0xXXzKSmqoz1NHJItPMqVg6FHa5mfuRLXrW4XCmVade7n6uSm7YhzVGaIsXs4g4AK6PYIi5BgEGBER2y1dJhlMiVX59YIaEdJ9utOysgWYXpxqHotURpsfBaId5awD3DlJDTRNyzfzf3xGltLZnY7g9w2xw1DJsmCYP2tWB+/Bpw/4vdEIDOp9W0BLqzdxO0+EphweaIy0XiEq7FSmSqrdFoTEb3h71yzKTAdbiHTQrETE6+nzUTXdWTSnG77cssM9W/15vb4mOxuTgzTxtQUZRtVZi1qmUFq2p+2rItFxAXcNHRZbR7L1cYKBkAzamXnUs/P6R2PnmnxHg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWmXGKsCRn6XMZUU0aakAw3vXFUwaVNrv4fWtNRsXDo/sHHdy69Z7w56P8e92GgIz0CmQ0/WpqPjXaybwEotleJ2RPegNUZME6wOyesejo3T47x23BycyG7Pg3q/681vBUAwUuDPLZDjxCOPuTo5s6XqcawG2DOHHg6J5aSgaUPmS9tV+wXa/AdCtHSE+zzonMSYA/174RKjc5581cdeZcmUZZ1KA1NJYy8MKaVajs+OXtrKytz52cE4imHAzkzfU5WyOn1pd8sHV423xjr2UxQJKH4jofzIEhQmWUDBzjFFqN6iter4GhPgHDvVnlrnd/5ZtcdhQt9sdVHxwhEurQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 01:29:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYcZr+xugQmCaBT0SxSahY0q90Lq2En0iAgAAEOQCAAJWm8A==
- Thread-topic: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH v2 0/4] tools/xenstore: add some new features to the
> documentation
>
> Hi Jan,
>
> On 18/07/2022 17:12, Jan Beulich wrote:
> > On 27.05.2022 09:24, Juergen Gross wrote:
> >>
> >> Changes in V2:
> >> - added new patch 1
> >> - remove feature bits for dom0-only features
> >> - get-features without domid returns Xenstore supported features
> >> - get/set-quota without domid for global quota access
> >>
> >> Juergen Gross (4):
> >> tools/xenstore: modify feature bit specification in xenstore-ring.txt
> >> tools/xenstore: add documentation for new set/get-feature commands
> >> tools/xenstore: add documentation for new set/get-quota commands
> >> tools/xenstore: add documentation for extended watch command
> >
> > Hmm, looks like I did commit v1 of this series, not noticing the v2 _and_
> > seeing there had been R-b with no other follow-up (leaving aside the v2)
> > in a long time. Please advise if I should revert the commits. I'm sorry
> > for the confusion. (I also wonder why the R-b weren't carried over to v2.)
>
> patch #1 is a new patch. The patch #2, #3, #4 have been reworded and the
> overall interaction is different. So I don't think the reviewed-by
> should have been carried.
>
> I had some concerns in v1 which were addressed in v2. I have reviewed v2
> a while ago. From my perspective, patch #1, #3, #4 are ready to go.
> Patch #2 needs a respin and we also need to clarify the integration with
> migration/live-update.
>
> As you committed, I would be OK if this is addressed in a follow-up
> series. But this *must* be addressed by the time 4.17 is released
> because otherwise we will commit ourself to a broken interface. @Henry,
> please add this in the blocker list.
Thank you very much for this information. I've added this in blocker list.
I will keep that in mind and send (proper) reminders during the timeline
of the 4.17 release process.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
