[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI
- To: Pau Monné, Roger <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Tue, 19 Jul 2022 07:33:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jufNV3nxQkFwocZat4wcTsVyyuEHjh01WxwsvJNYDGI=; b=KPKGSsHt8GeV0l8QpZ0rVBI5yPKgcLSZlt4qli5uBcrVG3MQwwNRhwX1A/jt8te3tCvG2Wx6VwA45bJ+hhTvaw57fZTM5IyiYqJqMnJgESh5lWLHAHME7hiuUvVpLX3mI2dm3qfYa+Q5Nl4smmX6wMuiiFKfWqXZo5lB+eypMwZ+Kj1auC6wRmiWjP4ZuCGuYYcecMf+mWq57uXz95d+FwoLfPj3ahpz+FAbuNFM3daP3syIaU+psz5H0mYX3xri9TmIk7mT0pM+2pRJhf4Oi0IPHH0ZnENNeEUXFI+7rpLB2BJRaUo2St75dVQf3wBwIE5wXFZ9gKZ7NjJyusWfVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5zi4Zws0niGOpUXIfoTy9MMa2g7IAD9r6tkrijjUHNIXDz6BlFQNr6C5JHeckCraXju9vF1PeEtvox7VQbULSl28+7192dld4AFsgADV6Ng1AQwJF4AvD9iABznduAcmUS+uMX/BA3UCnV2jYiB+F0XqZ0RPvRY0vomKe1TFhSLjX0vhUpLjiA+ARvj0t+Y3LxDewqFwwj6i2uaJkEY3MRjGkjrw2HbN+mVUGZ3JgPsgj7IYsUIGC0tG8eKZ9Zslz9UudjgwCODtsb/MDOCgaTb0/D0q6esdRHz15mw4c7uQCURmfA+PH5tHQJKDSTr9dz9dcS+eBoH0rzzf7HpYw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: Pau Monné, Roger <roger.pau@xxxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Beulich, Jan" <JBeulich@xxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 07:34:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYjUzyHVJg5Vl520WKm8Qoee4tTK2FaJfg
- Thread-topic: [PATCH v3 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Sent: Friday, July 1, 2022 9:17 PM
>
> @@ -225,6 +225,9 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc)
>
> /*
> * Interruption-information format
> + *
> + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit
> Qualification
> + * field under some circumstances.
> */
> #define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */
> #define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */
Overall this is good. But I wonder whether the readability is slightly better
by defining a dedicate flag bit for exit qualification with a clear comment
on which events it makes sense to...
|
