[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 06/18] fdt: make fdt handling reusable across arch
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Jul 2022 11:36:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKUbbPv7+dRxb1QL6FA+0ZSJh/h0yAdGOQWjDusTHwg=; b=fhUx1txzi71GRogv39oJuwZkg2G0ycj9xMybVMdwKCBx+/SujhuUMfy9b5cTVfI8ho+cuiFNSJGL5LHX06sikNISUrGz0alK4YH9EICOOF9V2eJvjD9zcKV0wyTmYY+p7dD1ibO6RRqfYScl2gfZuBXGYR8g/iJM39+DNV+4kLu2Sgwr2LJ+rJZuFlv/tzW0fN+NWG9+YJrnO8BQ7DdKgqKW4hTf/3LYRMfatFhgU7L96DLvqZk2PCTMXS0o4bCltRwzmQn+0s9YRA2a8XcEIeTBgzgHJ4pOM6A1aPvBljbNbR5FbebfacDjQ7vij4SDRhUpm5OJxz1Jo/cIwxW0Pw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUckE3dvkHn4P/wKeqyN5BGwM+vW5uYJ2JGlsoqLQTDibrydhgH2lp+JB5sInkAA2JrwBo8KxGi1D4bcI3/YEXuffn72wOizsCOYrala5ZNu2FdJF3shci7NaW5lCBQKzqPB0JWmg4QxPS36iDwG1GE4PeEdIRblLO5vV1UWomsfU8MKnApu/rlwByl8EtMUfAYpEbF8a5QW28NVoVivRxwmIpnUgRGuUMrrr8+b0DZRe0mg91yUI0urPG4ordo0+xS0lWt/866qeBuFpqI6yaU/qPWcOd2F1TUl1hKYxJKfyQFOqLuYr6dmkEmcXqhanJHHBHCyl7iKd7FrOqXz/g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: scott.davis@xxxxxxxxxx, christopher.clark@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 09:37:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2022 23:04, Daniel P. Smith wrote:
> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is
> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is
> introduced for when the ability of parsing DTB files is needed by a capability
> such as hyperlaunch.
>
> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Christopher Clark <christopher.clark@xxxxxxxxxx>
> ---
> xen/arch/arm/bootfdt.c | 115 +----------------------------
> xen/common/Kconfig | 4 ++
> xen/common/Makefile | 3 +-
> xen/common/fdt.c | 131 ++++++++++++++++++++++++++++++++++
> xen/include/xen/device_tree.h | 50 +------------
> xen/include/xen/fdt.h | 79 ++++++++++++++++++++
> 6 files changed, 218 insertions(+), 164 deletions(-)
> create mode 100644 xen/common/fdt.c
> create mode 100644 xen/include/xen/fdt.h
I think this wants to be accompanied by an update to ./MAINTAINERS,
so maintainership doesn't silently transition to THE REST.
I further think that the moved code would want to have style adjusted
to match present guidelines - I've noticed a number of u<N> uses which
should be uint<N>_t. I didn't look closely to see whether other style
violations are also retained in the moved code.
Jan
|
