[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 05/18] x86: refactor xen cmdline into general framework
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Jul 2022 15:26:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=++1L7owZW5MTQlMNcXjYhazYBSWrdakj9jpM3QNOotc=; b=Qvgjm51Fo2epIAtyhyfXUKAcbUNvFdJGvKObIsqu7FYc37jTMydjK5/Y5r8S//0dNwp64ZzSxqsPRqh4LcpiOcaHvFYvcgAFl4/GTckh51EXhUFccO27I+GWP8uWXWecrzdEcVVxB2Y6PIQ0tF50HdsemNhjrcFeXTsXHcPuWPFZAGOo6xTp5EwS1YhJ344JtmQQpqUEWWLvx/RYUtcQBAYnci21uOszIExq730DTkxDCVRavs5Kl/8Fiv2aZQBIvev+PAnOc+x9vuKiQt/DRZxlwS+rrlzrZ3qio4sp2/b510LLS4nrAQI/HXwb/IdEdyyAP2rychycrZRnt3yZHQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxHLJI5p02RgEhRbeS8hKbu42u6njeyo/N8Muz02p6myhfzjMMFr2U7BYx0ZuGojGKM2IpnlpSVyN/Pn/oBcBpVCxWFDJLU3JgHfpxH7sFDUXu8W2q4sQxSnmt8/ouPt8hCV47zSZ3wpqzHGfL8rOZq79xQ4WQKAqDqJ4nnrwuuZJVKLxwuhvR0eSheFz5vV1sZ1OmqZ2lv2PAyp3B/AD4rXF2sX93kh5dg4YryDN6/QBSabGFP/P4DpU5NBrPKkK1go8GOIsQg/Ebus8lN8to0VOmzx0VGUFVRQpjKOY8rVAwJBb/LY+oQhxruHtB5rAOmmXHBTPLjS2RCIg4OzzA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: scott.davis@xxxxxxxxxx, christopher.clark@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 13:26:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2022 23:04, Daniel P. Smith wrote:
> --- a/xen/include/xen/bootinfo.h
> +++ b/xen/include/xen/bootinfo.h
> @@ -53,6 +53,17 @@ struct __packed boot_info {
>
> extern struct boot_info *boot_info;
>
> +static inline char *bootinfo_prepare_cmdline(struct boot_info *bi)
> +{
> + bi->cmdline = arch_bootinfo_prepare_cmdline(bi->cmdline, bi->arch);
> +
> + if ( *bi->cmdline == ' ' )
> + printk(XENLOG_WARNING "%s: leading whitespace left on cmdline\n",
> + __func__);
Just a remark and a question on this one: I don't view the use of
__func__ here (and in fact in many other cases as well) as very
useful. And why do we need such a warning all of the sudden in the
first place?
Jan
|
