[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 21 Jul 2022 09:42:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79p6noFtPNzf+9uwJyf6reWBzGOEK97mk6XUY2WmVTc=; b=Vxj3MG/JlzqvuX3GdNWJjTABWvHME+SLJYsJnsWGXaui6CRwHuvCE1iYM4+vCxwkAv/WVAVagrKa6x7XelsoN2/F6mZGjn/DQOGAJhmYd0ub63ggV4WXm1fBRSL6nJmBxiXRQ1qvzF3mcKZM54RYh7dDkXey6bAbFQSaBFavZEZmPAdgyH9UHpWJozQM7+ZxPu0nar0v7Y97bAAoeHGJsw3sNgVB4sXq48srOR9J6qZYoXOnpv0z9/KoqvEujX+PPcf7zUMEdUuFym0uP4b5+GVPmOJSjkiq2cXBboeQX5RbukZ6wQSUJ63u4KcuNuM6I+63hIk2FZbJ3j7ZNGLI5A==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79p6noFtPNzf+9uwJyf6reWBzGOEK97mk6XUY2WmVTc=; b=EDE+VaEKJsYQmtqypXG+x/Hx9vHguwPIXSOancLD8a5VQqBk8Bw/Urb2LFRBdi15VADeyQ6kHiMHn5iHkpE16aWYvTJbrS8r6rgo2jkb4Is4wXzd2dLd5/PEMOzisjGD87f2W/xXA/lzNv9y7ituRKkvK9YjNycIeFW0TKJxWcmZ7lbx3jUWz2MGeRTgKuXEIp/4Ne+TcuXmOIq/rKmrwBNoFZ+eMRr9ebehSix5MGcCZtAtbsnsCwsbWg1OD+YlAzOuGpdjrRGTRsfGmM3bnhS1jbku62FNtD4NuIdTWAYcXO+5XyCufOKRnCmdtqg3HYcI+HMnimypZvbkMcQtYw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Whk8vEsqthChGTwxVe/r8ZituPH/cjgqWWDkCiWzG31Oh89Yfv4tdTYRdQd61zE7lyR4xtyrUMKMyNGqbWXUmW9ShbDcWRnagEHYtMvf3apxBQI9YWT293ZUL+Ul+55gRxr/UpIqwEk4NMbvSXltff7QL9eP/7INiiAL2MKayAKn4PNtDttXIv2CBhZOnvnrBod2KHFZhsxUhmhRFtSf+MRYXP6ncf4ofFW37LLq7PUNbNvPfxTSPTcIBuI5NoxxzTouVaY51y9bxvb74x7D62LCxmneQuFu46e5hMcoRnFQJu9lwt3qP7nRW7jLT1T66ds8LvE/CKWRCjA100LJWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fz0QuozorezgFuvH6OsZkPTKZM+hLYmEwdU+TbpHBY48fvVHIA+/dPRgyXNoyL29B0ve6gNaGnSMT4ipEvg51Ljqr2Lsh3p5etO2ueWVXE96lE9nKljZQquPcdTwSX5rHF5HBla6nIdS9D/gPRK8dgeFoWTi6BwvRDcMqhLBF8j1PRdsjdY3U0DxqsCSSxCRBaVhSXsr9V0TXEV4kzgyWQw5arkSvlUQP0Pmey+rDfKY0wEr2AarCAAyZ3vtljmQ7dPU8MTySff9BCNb1+Od03GqOkBX7vyQgg/tNmqyvc03+hD+FRaYWe2pRsadQsqKlbh/6ng4nkwCRD8+8NfrDA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 21 Jul 2022 09:42:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYnGjqn9ie7DwPZ0aph4nZF/OvCK2Ik3AA
- Thread-topic: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization
> On 20 Jul 2022, at 19:44, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, the domheap mappings initialization is done separately for
> the boot CPU and secondary CPUs. The main difference is for the former
> the pages are part of Xen binary whilst for the latter they are
> dynamically allocated.
>
> It would be good to have a single helper so it is easier to rework
> on the domheap is initialized.
>
> For CPU0, we still need to use pre-allocated pages because the
> allocators may use domain_map_page(), so we need to have the domheap
> area ready first. But we can still delay the initialization to setup_mm().
>
> Introduce a new helper init_domheap_mappings() that will be called
> from setup_mm() for the boot CPU and from init_secondary_pagetables()
> for secondary CPUs.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
Hi Julien,
With Bertrand's comment addressed:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
I’ve also tested with fvp using aarch32 configuration starting Dom0 and few
guests
and everything works.
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
