[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 08/25] tools/libfsimage: Cleanup makefiles
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 22 Jul 2022 12:07:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mG94UoF7MulTzX8cPfIShSOi+i1WGT5N+9up7TGyqt8=; b=fjOrxQzd3q3K2xGonXNhlkDqJ0tMUWtNBAksS2YG4f3xSlSV2O2wHh4bhQ5sw9mSLCl0zRQW5J8KiNUV7EXd0628XHIL3dXP7wFWCP9Al9V1OOxCUZDjsA5+4Pq7G8D981v1eWCJDP/HDyLviKml/1XrSZzZlSZcVsl4/Ja/7wet7Se1zJ/ss313/H0444FEeOqyxbpyBPkOoouTjxNu6axuImOjNA38VTCqzZM8D5QGFWvZOH2QAUMB7kBI6HefVw4SOrdmBWCPwC1yq3d+iS05iMrpBtFYry4BGcVV0FNz+r/rzwrZlCqBZ1yRd06/EdDGiTGN1xYSn7kcr0z8hg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mG94UoF7MulTzX8cPfIShSOi+i1WGT5N+9up7TGyqt8=; b=UXww7AhuvepluhFCpAKLvYwdbk1GYE4WZ0ycW7O3LQ1UebHTxVosqayjJ+CohXalO/JCrwWRCXNcPgu6dhBix2TniKoswraVsJ2GTTMbl5cmZRwWr7lWNa9hAG9bwNDmWARWQBturUNg+1Om2eZ+9OTFi4OyeQdZg0LP0u9TJTjX8sl+HOYeMoUUr8ohF+MWQ4xcXAFfRMydHfp4J/sGYtnn07vGsflLzWtLT05LuWJWz5rCEvTq52GzdxQhXCBM5bTNt47Z20HvZ+EVqHuT4fBvviMuk2iI5gUaG3vaSJzxxO7IlBjsyxJgurYo9koZfi/rl5FzU8mQOEXHHCdQ6w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jhT0+WS0X0V9Gph6T5FiyFc/A9PZ1782w8q+y7UnSzsX6OuSseAlUOXO0p7gkHxp2+h6ejQr0pir4usSj8RMoRwtvrdMz3aRykvOL7YaOGVjL5QpCDxO3T7kiyxJcu7vE0TFIckOJNYXmPQPgq+zA/B+XyWgUz3KSbNeAycu+z01IdLX0ns4Ftxx+nXCcALQnh6DhVO+m7smY68Gh9QN/GzDzeicskgN9+xzhvXqjDbg4tjHF7saPyxgSowSohWQ+1Mf2KxsvbwFdLrOuiSUbfuItT9dfvSzW93OCjlAz/Xir+Y+Y7SqKNYu436rCOnK+lnbH6ECBdBcEsJDQOiMcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fFOUCIvd80ry/k7tAUgMNf/v+h4pwT8l7L4990qNoUppBhQruqkRpiZZGqGG6l2rStrbhs4CqQp1KpAwL857G4CNEXUIz2lGG7SUyltUrr4GpN1j2ljz8hBkT3BxVAXpBaSMjRSWuTZ578GseYR7cLCKGYTOXQI8r0mLySJ2xJjHqsGa1lVHAN+9tVbTsZSDjjJxBEaoJH0dDmbIOnx7PFZecHh0MWNBNp8dkZ2hcUqic3iBRuiiXrrGh1M7W7bhCjdsTYuDzEb6U1fKv2PGnZSWWbZ5dHytOTWWmEUZhcdKlgYAT9POpGd7vV3vkOQx2yIyr1nug7ZGdf3l6O4xTQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 22 Jul 2022 12:08:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+Qs/zKTqDbfTEaHrzjY08GxPa2Kd3UA
- Thread-topic: [XEN PATCH v3 08/25] tools/libfsimage: Cleanup makefiles
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Remove the need for "fs-*" targets by creating a "common.mk" which
> have flags that are common to libfsimage/common/ and the other
> libfsimages/*/ directories.
>
> In common.mk, make $(PIC_OBJS) a recursively expanded variable so it
> doesn't matter where $(LIB_SRCS-y) is defined, and remove the extra
> $(PIC_OBJS) from libfsimage/common/Makefile.
>
> Use a $(TARGETS) variable to list things to be built. And $(TARGETS)
> can be use in the clean target in common.mk.
>
> iso9660/:
> Remove the explicit dependency between fsys_iso9660.c and
> iso9660.h, this is handled automaticaly by the .*.d dependency files,
> and iso9660.h already exist.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Hi Antony,
Looks good to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
